Ability to ping code owners in PRs and discussions

[dmitryax]

I'd be nice to be able to automatically ping code owners by adding labels in PRs and discussions, not only issues.

[dmitryax]

@evan-bradley WDYT?

[evan-bradley]

I like that idea. Code owners who are not approvers/maintainers do not get notified automatically in PRs because of how the GitHub CODEOWNERS file works, so that could simplify the process of asking for a review. Discussions could also benefit since they're like issues.

[evan-bradley]

Discussions aren't supported in the GitHub CLI, so we will only be able to do PRs for now.

[dmitryax]

Discussions aren't supported in the GitHub CLI, so we will only be able to do PRs for now.

Sounds good. Thanks for adding the support of PRs!

[dmitryax]

@evan-bradley I see that PRs are getting labels automatically which is cool but it doesn't seems that pinging code owners work

[evan-bradley]

Do you have an example where it isn't requesting a review? I have seen a few instances where code owners aren't added to a PR, which I believe is because someone in the request isn't part of the OpenTelemetry organization. For normal cases it appears to add code owners when it adds the label.

[dmitryax]

You're right. They are not members of the organization. For example, I submitted #16302 and none of the 3 code owners weren't notified. I think we should ping them if we cannot assign reviewers

[evan-bradley]

That makes sense to me. It's a little more involved than adding them as reviewers, so I've opened an issue here to outline approaches we can take: #16326.

[dmitryax]

Sounds good. thanks. closing this one then