Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger UI SPM spanmetrics not working in 0.85.0 #26712

Closed
bangbaew opened this issue Sep 15, 2023 · 4 comments
Closed

Jaeger UI SPM spanmetrics not working in 0.85.0 #26712

bangbaew opened this issue Sep 15, 2023 · 4 comments
Labels
bug Something isn't working needs triage New item requiring triage

Comments

@bangbaew
Copy link

Component(s)

No response

What happened?

Description

I updated to v0.85.0 and Jaeger UI spanmetrics stopped working in SPM page,
It worked fine in v0.84.0 with the same settings.
I think it has something to do with #26546

Steps to Reproduce

Update to v0.85.0

Expected Result

image

Actual Result

image

Collector version

v0.85.0

Environment information

Environment

Docker Image otel/opentelemetry-collector-contrib:0.85.0 on Ubuntu AKS

OpenTelemetry Collector configuration

receivers:
  jaeger:
    protocols:
      thrift_http:
        endpoint: "0.0.0.0:14278"

  otlp:
    protocols:
      grpc:
      http:

exporters:
  loki:
    endpoint: http://loki:3100/loki/api/v1/push

  prometheusremotewrite:
    endpoint: http://prometheus:9090/api/v1/write
    target_info:
       enabled: true

  otlp:
    endpoint: jaeger:4317
    tls:
      insecure: true

  zipkin:
    endpoint: "http://zipkin:9411/api/v2/spans"
    format: proto

connectors:
  spanmetrics:
    exemplars:
      enabled: true

processors:
  batch:
  attributes:
    actions:
      - action: insert
        key: loki.attribute.labels
        value: container
      - action: insert
        key: loki.format
        value: raw

service:
  pipelines:
    logs:
      receivers: [otlp]
      processors: [attributes]
      exporters: [loki]
    traces:
      receivers: [otlp, jaeger]
      processors: [batch]
      exporters: [spanmetrics, otlp, zipkin]
    metrics:
      receivers: [spanmetrics]
      exporters: [prometheusremotewrite]

Log output

No response

Additional context

No response

@bangbaew bangbaew added bug Something isn't working needs triage New item requiring triage labels Sep 15, 2023
@codeboten
Copy link
Contributor

To clarify, v0.85.0 didn't include #26546. The change that did make it into v0.85.0 is open-telemetry/opentelemetry-collector-releases#396, which removed the two exporters from the manifest. I'm not sure I understand how this would have been caused by that change.

There were additional changes to the Jaeger receiver that are listed in https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.85.0 that may be causing this issue. @frzifus any thoughts?

@frzifus
Copy link
Member

frzifus commented Sep 16, 2023

hm.. It should not belong to each other. Mainly for two reasons:

  1. receiver.jaegerreceiver.replaceThriftWithProto is disabled by default. Which means the behavior should be the same as before.
  2. receiver.jaegerreceiver.replaceThriftWithProto only affects the remote sampling part. Which should not be related to the spanmetrics.

@pavolloffay any idea?

@thiagogcm
Copy link

thiagogcm commented Sep 18, 2023

Probably related to this: #26489
The following Jaeger configuration works for me with opentelemetry 0.85:

allInOne:
  image: jaegertracing/all-in-one:1.49.0
  options:
    log-level: info
    query:
      base-path: /jaeger
    prometheus:
      server-url: http://prom-prometheus-server.istio-system
      query:
        support-spanmetrics-connector: true
        normalize-calls: true
        normalize-duration: true
  metricsStorage:
    type: prometheus

@bangbaew
Copy link
Author

normalize-calls: true
normalize-duration: true

Probably related to this: #26489 The following Jaeger configuration works for me with opentelemetry 0.85:

allInOne:
  image: jaegertracing/all-in-one:1.49.0
  options:
    log-level: info
    query:
      base-path: /jaeger
    prometheus:
      server-url: http://prom-prometheus-server.istio-system
      query:
        support-spanmetrics-connector: true
        normalize-calls: true
        normalize-duration: true
  metricsStorage:
    type: prometheus

I tried adding these 2 environment variables and it works now!
PROMETHEUS_QUERY_NORMALIZE_CALLS=true
PROMETHEUS_QUERY_NORMALIZE_DURATION=true
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

4 participants