Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky test][receiver/jaegerreceiver/internal/jaegerreceiverdeprecated] TestPortsNotOpen: hard coded port already in use #29276

Closed
pjanotti opened this issue Nov 14, 2023 · 7 comments

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Nov 14, 2023

Component(s)

receiver/jaeger/internal/jaegerreceiverdeprecated

Describe the issue you're reporting

Many failures for this test at #28682

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6865022333/job/18668070125#step:6:351

--- FAIL: TestPortsNotOpen (0.00s)
    trace_receiver_test.go:129: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/jaegerreceiver/internal/jaegerreceiverdeprecated/trace_receiver_test.go:129
        	Error:      	Received unexpected error:
        	            	listen tcp 127.0.0.1:14250: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
        	Test:       	TestPortsNotOpen
        	Messages:   	should have been able to listen on 14250.  jaeger receiver incorrectly started grpc
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/jaegerreceiver/internal/jaegerreceiverdeprecated	1.731s
Copy link
Contributor

Pinging code owners for receiver/jaeger: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added the flaky test a test is flaky label Nov 14, 2023
@crobert-1
Copy link
Member

Looks like a flaky test to me. The jaeger receiver requires access to port 14250 from what I can tell, so the test itself is valid ensuring it can correctly connect to 14250. Also seems flaky as we don't have any other occurrences of this test failing.

I think it would make sense to update the test to add a check at the beginning to ensure the environment is not already using port 14250. Maybe skip the test if it's already in use?

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Nov 20, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 22, 2024
@crobert-1 crobert-1 removed the Stale label Jan 22, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 25, 2024
@jpkrohling
Copy link
Member

Maybe skip the test if it's already in use?

I don't think this is the right solution: we might have the false impression that this test is running and passing. I'd rather try to gather as much information about the test owning the port as possible, and ensure that all tests are releasing the resources they allocate.

@github-actions github-actions bot removed the Stale label May 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 1, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants