supervisor does not consistently use property "storage.directory" to store effective yaml, agent.log

[cforce]

Component(s)

cmd/opampsupervisor

What happened?

Observations from testing

config file changes
YAML

storage:
  directory: /home/root/myfolder/super_check

contents of /home/root/myfolder/super_check after running supervisor

root@:~/super# ls /home/root/myfolder/super_check
persistent_state.yaml

Contents of directory from where supervisor was run

root@:~/super# ls
agent.log         effective.yaml    otelcol supervisor     supervisor.yaml

storage: what we give applies for persistent_state.yaml file not effective yaml file.
effective.yaml file is still created in same directory from where supervisor was run

Collector version

master

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan @BinaryFissionGames

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[BinaryFissionGames]

Yeah, we definitely should be putting any files the supervisor creates under the storage directory. I'll take this on.

[cforce]

After a first test it look like "effective.yaml" file is still in same directory as supervisor and not in the configured one.
The change shall cover all files which are created to be located only in the configured folder, shouldn't' it?
@BinaryFissionGames

[BinaryFissionGames]

After a first test it look like "effective.yaml" file is still in same directory as supervisor and not in the configured one. The change shall cover all files which are created to be located only in the configured folder, shouldn't' it? @BinaryFissionGames

It should cover all files, yeah.

I've given it another test off main (commit 7f79eba), and I'm seeing effective.yaml end up in my configured storage directory.

Can you confirm the commit you've built the supervisor off of? If you're still seeing the issue, it'd also be helpful to get a config for the supervisor that reproduces the issue. I'm also curious if this is happening on startup or on reconfigure.

[cforce]

based on tagged src i used git clone --branch v0.106.1 --depth 1 https://github.com/open-telemetry/opentelemetry-collector-contrib.git

server:
  endpoint: ws://localhost:9082/

capabilities:
  reports_effective_config: true
  reports_own_metrics: true
  reports_health: true
  accepts_remote_config: true
  reports_remote_config: true

storage:
  directory: ./yaml

agent:
  executable: ./otelcol

[BinaryFissionGames]

Ah, that explains it. The fix isn't in a release yet, it'll release in v0.107.0 (which should be happening today/tomorrow, from what I understand)