Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[obsreport] why the "/" is used for metrics of agent #9299

Closed
yutingcaicyt opened this issue Jan 17, 2024 · 2 comments
Closed

[obsreport] why the "/" is used for metrics of agent #9299

yutingcaicyt opened this issue Jan 17, 2024 · 2 comments

Comments

@yutingcaicyt
Copy link

Is your feature request related to a problem? Please describe.
In the Specification of opentelemetry, I haven't seen this usage in any examples or conventions. But in opentelemetry-collecotor, the convention for obsreport metrics is /<metric_name>.

Describe the solution you'd like
Could you let me know whether the convention in opentelemetry-collecotor is consistent with the Specification of opentelemetry?

@codeboten
Copy link
Contributor

I believe this is a side effect of the metrics having been initially instrumented using opencensus. You can see where support for / was added to the specification: open-telemetry/opentelemetry-specification#3422

See open-telemetry/oteps#238 for an OpenTelemetry Enhancement Proposal around semantic conventions for telemetry pipeline monitoring

@mx-psi mx-psi added this to the Self observability milestone May 24, 2024
@codeboten
Copy link
Contributor

The metrics generated have been moved to use _ as a separator. This makes the any metrics generated by the collector consistent regardless of whether the export is done via prometheus (which already did this automatically) or via another exporter (otlp, console).

I'm marking this as done for core. There are a few metrics still being migrated in contrib, but they're being tracked in open-telemetry/opentelemetry-collector-contrib#29867 and open-telemetry/opentelemetry-collector-contrib#33523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants