Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Add unit to Instrument selection criteria #1995

Closed
lalitb opened this issue Feb 22, 2023 · 1 comment · Fixed by #2236
Closed

[Metrics SDK] Add unit to Instrument selection criteria #1995

lalitb opened this issue Feb 22, 2023 · 1 comment · Fixed by #2236
Assignees
@lalitb
Labels
area:metrics OpenTelemetry metrics area:sdk bug Something isn't working do-not-stale
Milestone
Metrics post GA r...

Comments

@lalitb
Copy link
Member

lalitb commented Feb 22, 2023

As per the specs changes - open-telemetry/opentelemetry-specification#3184, Unit should used in Instrument selection criteria defined in View API.

Changes would be potentially required here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/metrics/view/meter_selector.h
@lalitb lalitb added bug Something isn't working area:metrics OpenTelemetry metrics area:sdk labels Feb 22, 2023
@lalitb lalitb self-assigned this Feb 22, 2023
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Apr 24, 2023
@esigo esigo added do-not-stale and removed Stale labels Apr 25, 2023
@lalitb lalitb mentioned this issue Jul 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
area:metrics OpenTelemetry metrics area:sdk bug Something isn't working do-not-stale
Projects
None yet
Milestone
Metrics post GA release - 2
Development

Successfully merging a pull request may close this issue.

[Metrics SDK] Add unit to Instrument selection criteria lalitb/opentelemetry-cpp
2 participants
@lalitb @esigo