Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inject agent/sidecar through opentelemetry-operator annoatatons. #243

Closed
JaredTan95 opened this issue Aug 1, 2022 · 0 comments · Fixed by #244
Closed

support inject agent/sidecar through opentelemetry-operator annoatatons. #243

JaredTan95 opened this issue Aug 1, 2022 · 0 comments · Fixed by #244
Labels
enhancement New feature or request

Comments

@JaredTan95
Copy link
Member

JaredTan95 commented Aug 1, 2022

support inject agent/sidecar through opentelemetry-operator annoatatons.

I found we packaged otel agent jar into docker images, and set default jvm options.

https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/adservice/build.gradle#L103
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/adservice/Dockerfile#L32

But ,I think this way maybe couldn't works well with opentelemetry-operator.

Describe the solution you'd like:

I wuold like to remove default jvm options and use JAVA_TOOL_OPTIONS env in dockerfile.
So that, uses could use their own or deffirent versions agent. and It also could be override by opentelemetry-operator sidecar.

@JaredTan95 JaredTan95 added the enhancement New feature or request label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant