From 6ebad82d799ef497be36b6a8990a229093effbf2 Mon Sep 17 00:00:00 2001 From: John Du Hart Date: Tue, 13 Apr 2021 21:57:23 -0400 Subject: [PATCH] sqlclient: remove duplicate db.system settag --- .../Implementation/SqlClientDiagnosticListener.cs | 1 - .../Implementation/SqlEventSourceListener.netfx.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs index 6ddae984058..ce88d82ec03 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs +++ b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs @@ -87,7 +87,6 @@ public override void OnCustom(string name, Activity activity, object payload) _ = this.dataSourceFetcher.TryFetch(connection, out var dataSource); _ = this.commandTextFetcher.TryFetch(command, out var commandText); - activity.SetTag(SemanticConventions.AttributeDbSystem, SqlActivitySourceHelper.MicrosoftSqlServerDatabaseSystemName); activity.SetTag(SemanticConventions.AttributeDbName, (string)database); this.options.AddConnectionLevelDetailsToActivity((string)dataSource, activity); diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs index 5441e5ea7b0..aaf97663e68 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs +++ b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs @@ -143,7 +143,6 @@ private void OnBeginExecute(EventWrittenEventArgs eventData) if (activity.IsAllDataRequested) { - activity.SetTag(SemanticConventions.AttributeDbSystem, SqlActivitySourceHelper.MicrosoftSqlServerDatabaseSystemName); activity.SetTag(SemanticConventions.AttributeDbName, databaseName); this.options.AddConnectionLevelDetailsToActivity((string)eventData.Payload[1], activity);