-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-build-tools to v0.1.0 #2839
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
=====================================
Coverage 69.3% 69.3%
=====================================
Files 145 145
Lines 6729 6729
=====================================
+ Hits 4664 4667 +3
+ Misses 1950 1948 -2
+ Partials 115 114 -1
|
github.com/spf13/viper v1.12.0 // indirect | ||
github.com/spf13/viper v1.13.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the culprit. We can add a replace back to v1.12.0 until golangci-lint fixes this behavior.
A summary for anyone interested.
I think our options are:
|
@MadVikingGod do you want me to add the replace? |
Looks like viper does not have a plan to fix the issue: spf13/viper#1431 |
The community agreed that disabling the linter, for the time being, is the better option. #2878 is the fix specifically for that. This can merge after. |
This PR is outdated. |
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com