Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MeterProvider/Meter structure to new_sdk/main branch #2800

Closed
11 tasks done
MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #2822
Closed
11 tasks done

Add MeterProvider/Meter structure to new_sdk/main branch #2800

MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #2822
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022 •
edited
Loading

Blocked by #2799

Add in the needed interfaces and high-level types for the new SDK design from new_sdk/example. This is not expected to be a fully working implementation.

sdk/metric

  • type Provider struct to act as the MeterProvider
    • func New(...Option) metric.MeterProvider creation and configuration function stub for *Provider
    • func (*Provider) Meter(name string, opts ...metric.MeterOption) metric.Meter method stub
  • type meter struct to act as a Meter
    • func (*meter) RegisterCallback([]instrument.Asynchronous, func(context.Context)) error method stub
    • func (*meter) AsyncInt64() asyncint64.InstrumentProvider method stub
    • func (*meter) AsyncFloat64() asyncfloat64.InstrumentProvider method stub
    • func (*meter) SyncInt64() syncint64.InstrumentProvider method stub
    • func (*meter) SyncFloat64() syncfloat64.InstrumentProvider method stub
  • type Option interface to be passed to New and will configure the Provider
    • type config struct stub
@MrAlias MrAlias changed the title Add interface structure to feature branch Add interface structure to new_sdk/main branch Apr 19, 2022
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 19, 2022

revised-metric-sdk-2022-04-19-1146

@MrAlias MrAlias changed the title Add interface structure to new_sdk/main branch Add MeterProvider/Meter structure to new_sdk/main branch Apr 19, 2022
This was referenced Apr 19, 2022
Closed
Closed
@MrAlias MrAlias self-assigned this Apr 19, 2022
This was referenced Apr 19, 2022
Closed
Closed
Closed
Merged
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented May 2, 2022

Closed by #2822

@MrAlias MrAlias closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

Successfully merging a pull request may close this issue.

Add MeterProvider/meter structure to new SDK MrAlias/opentelemetry-go
1 participant
@MrAlias