Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the new_sdk/main branch into main #2818

Closed
4 tasks
MrAlias opened this issue Apr 19, 2022 · 5 comments · Fixed by #3175
Closed
4 tasks

Merge the new_sdk/main branch into main #2818

MrAlias opened this issue Apr 19, 2022 · 5 comments · Fixed by #3175
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022

Blocked by all issues in https://github.com/open-telemetry/opentelemetry-go/milestone/22. This will be the last issue that closes the milestone.

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 19, 2022

This needs to include deleting the new_sdk/example branch. It will no longer be needed.

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 6, 2022

The PR number needs to be added to the changelog entries added in #3150

@MrAlias MrAlias self-assigned this Sep 6, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 6, 2022

Merging will orphan the following packages:

  • go.opentelemetry.io/otel/sdk/metric/aggregator/aggregatortest
  • go.opentelemetry.io/otel/sdk/metric/aggregator/histogram
  • go.opentelemetry.io/otel/sdk/metric/aggregator/lastvalue
  • go.opentelemetry.io/otel/sdk/metric/aggregator/sum
  • go.opentelemetry.io/otel/sdk/metric/aggregator
  • go.opentelemetry.io/otel/sdk/metric/controller/basic
  • go.opentelemetry.io/otel/sdk/metric/controller/controllertest
  • go.opentelemetry.io/otel/sdk/metric/controller/time
  • go.opentelemetry.io/otel/sdk/metric/export/aggregation
  • go.opentelemetry.io/otel/sdk/metric/export
  • go.opentelemetry.io/otel/sdk/metric/number
  • go.opentelemetry.io/otel/sdk/metric/processor/basic
  • go.opentelemetry.io/otel/sdk/metric/processor/processortest
  • go.opentelemetry.io/otel/sdk/metric/processor/reducer
  • go.opentelemetry.io/otel/sdk/metric/registry
  • go.opentelemetry.io/otel/sdk/metric/sdkapi
  • go.opentelemetry.io/otel/sdk/metric/selector/simple

Do we want to plan a deprecation strategy for these? (Related to #2328)

@jmacd
Copy link
Contributor

jmacd commented Sep 8, 2022

Question about go.opentelemetry.io/otel/sdk/metric/aggregator/exponential/mapping (which exists today and should stay somewhere).
I think it's OK if that package moves.

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 14, 2022

Question about go.opentelemetry.io/otel/sdk/metric/aggregator/exponential/mapping (which exists today and should stay somewhere). I think it's OK if that package moves.

Indeed, this needs to be migrated to the new SDK. Please create an issue and add it to the beta milestone so we can track the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
2 participants