Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the sdk/metric/view package #2837

Closed
4 tasks
MrAlias opened this issue Apr 20, 2022 · 1 comment · Fixed by #2926
Closed
4 tasks

Implement the sdk/metric/view package #2837

MrAlias opened this issue Apr 20, 2022 · 1 comment · Fixed by #2926
Assignees
@MadVikingGod
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 20, 2022 •
edited
Loading

Blocked by #2816
Blocked by #2817
Blocked by #2813

  • Add view match option functions
    • func MatchInstrumentName(name string) Option
    • func MatchInstrumentNameRegexp(re *regexp.Regexp) Option
    • func MatchInstrumentKind(k sdkinstrument.Kind) Option
    • func MatchNumberKind(k number.Kind) Option
    • func MatchInstrumentationLibrary(lib instrumentation.Library) Option
  • Add instrument view option functions
    • func WithKeys(keys ...attribute.Key) Option
    • func WithName(name string) Option
    • func WithDescription(desc string) Option
    • func WithAggregation(kind aggregation.Kind) Option
    • func WithTemporality(tempo aggregation.Temporality) Option
    • func WithAggregatorConfig(acfg aggregator.Config) Option
  • Add getter functions for the Config type
    • func (Config) Name() string
    • func (Config) Keys() []attribute.Key
    • func (Config) Description() string
    • func (Config) Aggregation() aggregation.Kind
    • func (Config) Temporality() aggregation.Temporality
    • func (Config) AggregatorConfig() aggregator.Config
  • Add helper functions for the `Config type
    • func (Config) IsSingleInstrument() bool
    • func (Config) HasName() bool
    • func (Config) Matches(lib instrumentation.Library, desc sdkinstrument.Descriptor) bool
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 20, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 20, 2022
@MrAlias MrAlias linked a pull request May 26, 2022 that will close this issue
Add view to metrics. #2926
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 9, 2022

Only remaining task is to allow aggregation configuration. This has been split to its own issue: #2950

@MrAlias MrAlias closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadVikingGod MadVikingGod

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

Successfully merging a pull request may close this issue.

Add view to metrics. MadVikingGod/opentelemetry-go
2 participants
@MadVikingGod @MrAlias