Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify OpenTracingShim creational patterns #3084

Closed
malafeev opened this issue Mar 31, 2021 · 4 comments
Closed

Simplify OpenTracingShim creational patterns #3084

malafeev opened this issue Mar 31, 2021 · 4 comments
Assignees
@IrisTuntun
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project

Comments

@malafeev
Copy link
Contributor

malafeev commented Mar 31, 2021 •
edited
Loading

Introduce builder or
instead of 4 leave only two by removing createTracerShim(OpenTelemetry openTelemetry) and createTracerShim() from OpenTracingShim class
@malafeev malafeev added the Feature Request Suggest an idea for this project label Mar 31, 2021
@malafeev malafeev mentioned this issue Mar 31, 2021
Merged
@jkwatson
Copy link
Contributor

I might rename this to just "simplify OpenTracingShim creational patterns" because we might want to go with a builder.

@malafeev malafeev changed the title OpenTracingShim: leave only 2 creational methods Simplify OpenTracingShim creational patterns Mar 31, 2021
@IrisTuntun
Copy link

Hi, can I take this issue?

cc @alolita

This was referenced Apr 7, 2021
Closed
Closed
Closed
@anuraaga
Copy link
Contributor

anuraaga commented Apr 8, 2021

Thanks @IrisTuntun for your interest in this issue! I think we should hold off temporarily until getting some input on this spec issue I filed

open-telemetry/opentelemetry-specification#1608

I am hoping we can reduce to just a single factory create(OpenTelemetry openTelemetry) to simplify both the usage but also the concepts.

@jkwatson jkwatson added the blocked:spec blocked on open or unresolved spec label Aug 25, 2021
@jack-berg
Copy link
Member

Resolved in #5110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrisTuntun IrisTuntun

Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
5 participants
@anuraaga @jkwatson @malafeev @jack-berg @IrisTuntun