Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: Ignore invalid arguments #5005

Closed
Tracked by #4911
carlosalberto opened this issue Nov 30, 2022 · 0 comments · Fixed by #5012
Closed
Tracked by #4911

OpenTracing Shim: Ignore invalid arguments #5005

carlosalberto opened this issue Nov 30, 2022 · 0 comments · Fixed by #5012

Comments

@carlosalberto
Copy link
Contributor

Both OpenTelemetry and OpenTracing APIs recommend keeping the reported errors to a minimum (in order to not crash the application), and hence we shouldn't throw any Exceptions upon getting invalid arguments as we do now. Logging them should be more than enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@carlosalberto