Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit to view instrument selection criteria #3643

Closed
pichlermarc opened this issue Feb 28, 2023 · 2 comments · Fixed by #3647
Closed

Add unit to view instrument selection criteria #3643

pichlermarc opened this issue Feb 28, 2023 · 2 comments · Fixed by #3647
Assignees
@jlabatut
Labels
feature-request good first issue Good for newcomers sdk:metrics Issues and PRs related to the Metrics SDK spec-feature This is a request to implement a new feature which is already specified by the OTel specification

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Feb 28, 2023 •
edited
Loading

As open-telemetry/opentelemetry-specification#3184 has merged, the next spec release will allow unit as an instrument selection criterion.

To implement this, we'll need to:

  • add instrumentUnit to ViewOptions
  • an ExactPredicate to the InstrumentSelector
  • additionally, see if the unit matches the instrument in ViewRegistry.matchInstrument() and add it to the expression there
@pichlermarc pichlermarc added good first issue Good for newcomers feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers spec-feature This is a request to implement a new feature which is already specified by the OTel specification sdk:metrics Issues and PRs related to the Metrics SDK labels Feb 28, 2023
@jlabatut
Copy link
Contributor

jlabatut commented Mar 1, 2023 •
edited
Loading

Hi, can I be assigned on this ? I have a PR ready (see #3647).

@jlabatut jlabatut mentioned this issue Mar 1, 2023
Merged
2 tasks
@pichlermarc pichlermarc removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 2, 2023
@pichlermarc
Copy link
Member Author

It's yours 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlabatut jlabatut

Labels
feature-request good first issue Good for newcomers sdk:metrics Issues and PRs related to the Metrics SDK spec-feature This is a request to implement a new feature which is already specified by the OTel specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add unit to view instrument selection criteria jlabatut/opentelemetry-js
2 participants
@pichlermarc @jlabatut