-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration code out of the main opentelemetry crate #403
Comments
Things that probably qualify:
|
👍 could also consider http and the testing utils as candidates |
For proto definition. I'd suggest we move it to a separate it into separate crate( |
If we need to support grpcio and tonic, those should probably be two separate crates IMO. |
I spent the morning looking at this. The I did remove the regex dependency (#411, in favor of a small function that validates the trace state key) and moved bincode to dev-dependencies (#413, along with some other dependency management). |
#415 moves the dependencies on http, reqwest and surf into a separate opentelemetry-http crate. At this point I'm inclined to leave tokio and async-std in, as they're pretty stable anyway (especially now that tokio has gone 1.0). |
@djc is the work related to this issue complete? or should we keep this issue open |
I want to mention that we need to update the doc in opentelemetry-rust/opentelemetry/src/lib.rs Lines 36 to 54 in f79586b
|
@TommyCpp thanks for taking care of the documentation update. I think this ticket is complete, closing. |
@TommyCpp yeah I think we could probably cut a new release, want to prepare the changelogs? |
Into separate integration crates. This makes for more smaller crates, but makes sure we don't have dependencies in the core that we shouldn't have (which causes to have to upgrade in lockstep with their releases).
The text was updated successfully, but these errors were encountered: