Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At git tag of v.1.12.0, the 1.12.0 schema file doesn't have the 1.12.0 attribute renames #2717

Closed
jship opened this issue Aug 8, 2022 · 1 comment · Fixed by #2720
Closed
Assignees
Labels
bug Something isn't working spec:miscellaneous For issues that don't match any other spec label

Comments

@jship
Copy link
Contributor

jship commented Aug 8, 2022

What are you trying to achieve?

When checking out the repo at git tag v1.12.0, I expected to see the span-related attribute renames in schemas/1.12.0. main at the time of this writing has the following renames listed in schemas/1.12.0:

1.12.0:
spans:
changes:
- rename_attributes:
attribute_map:
net.peer.ip: net.sock.peer.addr
net.host.ip: net.sock.host.addr

Tag v1.12.0 (at the time of this writing, tag is at commit ae87c81) has an empty 1.12.0 section:

Additional context.

Add any other context about the problem here. If you followed an existing documentation, please share the link to it.

@jship jship added the spec:miscellaneous For issues that don't match any other spec label label Aug 8, 2022
@jship jship changed the title At tit tag of v.1.12.0, the 1.12.0 schema file doesn't have the 1.12.0 attribute renames At git tag of v.1.12.0, the 1.12.0 schema file doesn't have the 1.12.0 attribute renames Aug 8, 2022
@arminru
Copy link
Member

arminru commented Aug 9, 2022

Good catch, thank you @jship!
The changes specified for v1.12 here were actually only applied on main and will be released in v1.13 within the upcoming days. They were introduced in #2614.
We'll fix the schema file before publishing the release.

@arminru arminru added the bug Something isn't working label Aug 9, 2022
@arminru arminru assigned arminru and unassigned yurishkuro Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants