Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide which JVM metrics should be included in initial stability #3419

Closed
trask opened this issue Apr 20, 2023 · 5 comments · Fixed by open-telemetry/semantic-conventions#56
Assignees
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented Apr 20, 2023

If we don't want to include some of them in the initial stability we can split them out into a separate section in runtime-environment-metrics.md titled "JVM Metrics (experimental)".

@trask trask added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Apr 20, 2023
@trask trask assigned trask and unassigned reyang Apr 20, 2023
@trask
Copy link
Member Author

trask commented Apr 21, 2023

The process.runtime.jvm.buffer.* don't seem critical for initial release if we want to leave them out.

@roberttoyonaga
Copy link
Contributor

What do we think about stabilizing the JFR gathered metrics? There's some useful ones like network IO, monitors, etc. But they would only apply to JDK17+.

@trask
Copy link
Member Author

trask commented May 12, 2023

  • process.runtime.jvm.memory.usage
  • process.runtime.jvm.memory.committed
  • process.runtime.jvm.memory.limit (.max?)
  • process.runtime.jvm.memory.usage_after_last_gc
  • process.runtime.jvm.gc.duration
  • process.runtime.jvm.threads.count
  • process.runtime.jvm.classes.loaded
  • process.runtime.jvm.classes.unloaded
  • process.runtime.jvm.classes.current_loaded
  • process.runtime.jvm.available_processors
  • process.runtime.jvm.cpu.time
  • process.runtime.jvm.cpu.utilization -> process.runtime.jvm.cpu.load

these would be nice but .system is confusing under .process (and under .jvm):

  • process.runtime.jvm.system.cpu.utilization -> process.runtime.jvm.system.cpu.load
  • process.runtime.jvm.system.cpu.load_1m

proposal is to make them opt-in and not include them in stability, and later explore putting them under system.*

No:

  • process.runtime.jvm.memory.init
  • process.runtime.jvm.buffer.usage
  • process.runtime.jvm.buffer.limit
  • process.runtime.jvm.buffer.count

@vijaysun-omr
Copy link

Could you please clarify the thinking behind process.runtime.jvm.memory.committed being in the "No" list ?

@jack-berg
Copy link
Member

jack-berg commented May 18, 2023

I'm in favor of including process.runtime.jvm.memory.committed for initial stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
Development

Successfully merging a pull request may close this issue.

5 participants