From 5247d1623ac096038bf56e6bdba1c7a99b097502 Mon Sep 17 00:00:00 2001 From: ChrsMark Date: Thu, 24 Aug 2023 11:38:41 +0300 Subject: [PATCH] review changes Signed-off-by: ChrsMark --- CHANGELOG.md | 2 ++ model/url.yaml | 12 ++++++------ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6faafa19c4..585dee085d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,6 +59,8 @@ release. ([#252](https://github.com/open-telemetry/semantic-conventions/pull/252)) - Simplify HTTP metric briefs. ([#276](https://github.com/open-telemetry/semantic-conventions/pull/276)) +- Add more ECS url fields. + ([#181](https://github.com/open-telemetry/semantic-conventions/pull/181)) ## v1.21.0 (2023-07-13) diff --git a/model/url.yaml b/model/url.yaml index c53d6e3521..631f9cf390 100644 --- a/model/url.yaml +++ b/model/url.yaml @@ -40,7 +40,7 @@ groups: - id: registered_domain requirement_level: opt_in type: string - brief: > + brief: | The highest registered url domain, stripped of the subdomain. For example, the registered domain for "foo.example.com" is "example.com". @@ -52,7 +52,7 @@ groups: - id: subdomain requirement_level: opt_in type: string - brief: > + brief: | The subdomain portion of a fully qualified domain name includes all of the names except the host name under the registered_domain. In a partially qualified domain, or if the the qualification level of the full name cannot @@ -65,7 +65,7 @@ groups: - id: top_level_domain requirement_level: opt_in type: string - brief: > + brief: | The effective top level domain (eTLD), also known as the domain suffix, is the last part of the domain name. For example, the top level domain for example.com is "com". @@ -87,7 +87,7 @@ groups: - id: extension requirement_level: opt_in type: string - brief: > + brief: | The field contains the file extension from the original request url, excluding the leading dot. @@ -103,7 +103,7 @@ groups: - id: domain requirement_level: opt_in type: string - brief: > + brief: | Domain of the url, such as `www.opentelemetry.io`. In some cases a URL may refer to an IP and/or port directly, @@ -120,7 +120,7 @@ groups: - id: original requirement_level: opt_in type: string - brief: > + brief: | Unmodified original URL as seen in the event source. Note that in network monitoring, the observed URL may be