Add Makefile to build and push the JupyterHub image #52
Conversation
|
@harshad16 could you please check if this is covered by our Tekton pipelines? I think a 'tag-release' workflow would be better than building the image on some random laptop... |
Makefile
Outdated
| VERSION=3.0.7 | ||
| FINAL_IMG_VERSION=$(VERSION)-$(COMMIT) | ||
| FINAL_IMG_URL=$(REGISTRY)/$(REPO)/jupyterhub-img:$(FINAL_IMG_VERSION) | ||
| S2I_ARGS=--with-builder podman |
There was a problem hiding this comment.
This is dependent on openshift/source-to-image#996 being merged, correct?
There was a problem hiding this comment.
Yeah, my bad, guess we should have docker by default till that PR is merged. So I changed it around - it will use docker now and there is a comment which suggest how to build with podman
vpavlin
force-pushed
the
feature/add-build-makefile
branch
from
7b62296
to
e6a7aa9
Compare
vpavlin
force-pushed
the
feature/add-build-makefile
branch
from
37dee0c
to
c322d47
Compare
|
is this something used for local development? Can we wrap the build and publish up in one of our pipelines? @AICoE/devops |
we can enable the pipeline to execute the makefile, however we would need to provide the bots (quay push bot) details to pipeline as the makefile it pushes the image to quay itself. |
|
You can call the makefile just to build the images, but I am not sure it is necessary to use it. I made it as an interim solution so that we at least have the build process documented and reproducible (so far it was just in our heads). I am happy to drop this in favour of something like Tekton Pipeline definition. |
ack. |
|
We now have Thoth pipelines setup, so we do not need this anymore |
No description provided.