Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from kubernetes.io/ingress.class to spec.ingressClassName #67

Open
alexellis opened this issue Oct 20, 2023 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@alexellis
Copy link
Member

Expected Behaviour

spec.ingressClassName needs to be set on Ingress records created by the operator

Current Behaviour

The kubernetes.io/ingress.class annotation is still being used, and is deprecated

List All Possible Solutions and Workarounds

Update reconciliation behaviour and test out the change with Traefik and ingress-nginx separately.

Context

At some point the warning will become an error.

 go run . --kubeconfig ~/.kube/config 
I1020 14:20:08.391934 3319312 main.go:51] Starting FunctionIngress controller version: latest-dev commit: local-dev
I1020 14:20:08.394413 3319312 controller.go:70] Setting up event handlers
I1020 14:20:08.394456 3319312 core.go:72] Waiting for informer caches to sync
I1020 14:20:08.494815 3319312 core.go:77] Starting workers
I1020 14:20:08.494842 3319312 core.go:83] Started workers
I1020 14:20:26.381036 3319312 controller.go:116] Creating Ingress for: nodeinfo
W1020 14:20:26.452110 3319312 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead
@alexellis alexellis added the help wanted Extra attention is needed label Oct 20, 2023
@nitishkumar71
Copy link
Member

I will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants