Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding last edit date for power contributors #3024

Open
1 task
teolemon opened this issue Sep 16, 2022 · 12 comments
Open
1 task

Adding last edit date for power contributors #3024

teolemon opened this issue Sep 16, 2022 · 12 comments
Assignees
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request P4

Comments

@teolemon
Copy link
Member

Problem

  • Adding last edit date for power contributors

image

@teolemon teolemon added ✨ enhancement New feature or request ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Sep 16, 2022
@anshpathania7
Copy link
Contributor

anshpathania7 commented Sep 16, 2022

where to add this in App?

@monsieurtanuki
Copy link
Contributor

I suggest you put it in edit product page, just under the barcode. That's a good starting point.

@anshpathania7
Copy link
Contributor

anshpathania7 commented Sep 17, 2022

@monsieurtanuki I have implemented this but in case of Null. Should we show the Text as "Not modified yet" or something like this to let user know ?

And should the Text "Last edited at" be Localized?

@teolemon
Copy link
Member Author

We could add the entry date if that's the case you're in ?

@monsieurtanuki
Copy link
Contributor

@anshpathania7 Just don't show the Text if the timestamp is null (personal opinion).
Of course "last edited" should be localized. So should the dateTime itself, I guess.
@teolemon I think we only have one timestamp in Product: DateTime? lastModified

@anshpathania7
Copy link
Contributor

anshpathania7 commented Sep 17, 2022

@teolemon So will it be an extra field named createdAt or existing lastModified field will have the value of created at?

@anshpathania7
Copy link
Contributor

@monsieurtanuki if we don't show Text in case of Null, it will be confusing for user, as they won't know if such Text exists or not.

@monsieurtanuki
Copy link
Contributor

@anshpathania7 It's just my personal opinion: as a user I would prefer to see nothing that a Text saying "Last modified: I don't know".
That said, you'd be better off asking @teolemon, who has the experience of the legacy apps.

@M123-dev
Copy link
Member

I agree the best solution would be to if null change it to "Created at" but until now we can make it not show

@teolemon
Copy link
Member Author

It's indeed a nice to have, so showing nothing at all is no big deal.
We have creation date ("Product created on XX/XX/XXXX") , and last edit date("Product created on XX/XX/XXXX and last edited on XX/XX/XXX"), so we should have 0 product where we can't show anything, excepted newly created products, when you are offline, and it hasn't been uploaded yet to Open Food Facts (we could show: "This product hasn't been sent yet to Open Food Facts")

@M123-dev
Copy link
Member

and it hasn't been uploaded yet to Open Food Facts (we could show: "This product hasn't been sent yet to Open Food Facts")

I guess it will always be on off if we are able to enter the edit page. We don't show something like that on the addition page.

But I guess we don't have the creation date in off-dart, do we?

@teolemon
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request P4
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

4 participants