Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brand autocomplete from openfoodfacts-search #4068

Closed
Tracked by #1379
teolemon opened this issue Jun 2, 2023 · 3 comments · Fixed by #4871
Closed
Tracked by #1379

Add brand autocomplete from openfoodfacts-search #4068

teolemon opened this issue Jun 2, 2023 · 3 comments · Fixed by #4871
Labels
autosuggest ✏️ Editing - Basic info input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Jun 2, 2023 •
edited
Loading

What

Add brand autocomplete, especially useful in autocomplete, and possibly complementing brand insights by robotoff

Part of
@teolemon teolemon added the ✨ enhancement New feature or request label Jun 2, 2023
@teolemon teolemon mentioned this issue Jun 2, 2023
Open
@teolemon teolemon added ✏️ Editing - Basic info input Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users autosuggest labels Jun 2, 2023
@teolemon teolemon changed the title Add brand autocomplete Add brand autocomplete from openfoodfacts-search Jun 2, 2023
@teolemon teolemon added the P2 label Aug 11, 2023
@teolemon teolemon added 🎯 P1 and removed P2 labels Dec 3, 2023
@teolemon
Copy link
Member Author

teolemon commented Dec 3, 2023

Bumping this one to P1 since:

  • @monsieurtanuki did the Dart part
  • many have waited for that for a very long time
  • it's one of the last fields to not benefit from autocomplete

@monsieurtanuki monsieurtanuki self-assigned this Dec 3, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon Don't know how relevant or easy that would be as we don't have PROD elastic search for the moment.
The best we can do is an access to DEV brands, assuling that is good enough.

@teolemon
Copy link
Member Author

teolemon commented Dec 3, 2023

Yes, that would be good enough given the low expected volume for brands, and given it's not too hackish.
We have planned a data center visit to upgrade things server wise, to enable broader deployment of search.

This was referenced Dec 4, 2023
Merged
Merged
@monsieurtanuki monsieurtanuki removed their assignment Dec 11, 2023
@monsieurtanuki monsieurtanuki mentioned this issue Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autosuggest ✏️ Editing - Basic info input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 4068 - autocomplete for brands monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki