Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to add basic details if they are not available #903

Closed
10 tasks
Tracked by #522 ...
teolemon opened this issue Jan 8, 2022 · 9 comments · Fixed by #1515
Closed
10 tasks
Tracked by #522 ...

Add the ability to add basic details if they are not available #903

teolemon opened this issue Jan 8, 2022 · 9 comments · Fixed by #1515
Assignees
Labels
✏️ Contribution ✏️ Editing - Text fields ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers help wanted Extra attention is needed 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1
Milestone

Comments

@teolemon
Copy link
Member

teolemon commented Jan 8, 2022

What

  • if product-name-to-be-completed or quantity-to-be-completed in states
    • Show a button at the bottom of the summary card to add basic details, which in turn might help Robotoff predict the category, and will make the product discoverable in search
  • Don't show the prompt button if the basic details are already completed
  • Implement the actual screen
  • Wire the actual screen to the button
  • Wire the actual screen to the full edit mode

Part of

Mockup

image

Basic details

@teolemon teolemon added ✅ task ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users help wanted Extra attention is needed and removed ✅ task labels Jan 8, 2022
@teolemon teolemon changed the title Add the ability to add Basic Details if they are not available Add the ability to add basic details if they are not available Jan 15, 2022
@teolemon
Copy link
Member Author

@jasmeet0817

@jasmeet0817
Copy link
Contributor

How about Brand name? Should that also be asked here?

We can also add the basic product info in product addition flow

@teolemon
Copy link
Member Author

  • Brand name possibly, yes.
  • Quantity and brand name can theoretically be inferred by Robotoff.

@teolemon
Copy link
Member Author

teolemon commented Jan 28, 2022

@teolemon
Copy link
Member Author

teolemon commented Feb 6, 2022

Here's an updated mockup:
Basic details

@teolemon teolemon added the 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. label Feb 23, 2022
@teolemon teolemon added good first issue Good for newcomers 🎯 P1 labels Mar 9, 2022
@bhattabhi013
Copy link
Contributor

bhattabhi013 commented Mar 25, 2022

I can create the UI/ UX for this screen and wire it to the button click.

@bhattabhi013
Copy link
Contributor

I can create the UI/ UX for this screen and wire it to the button click.

Should I work on it?

@M123-dev
Copy link
Member

Sure @bhattabhi013 but it would be even better if you could also make it functional. https://github.com/openfoodfacts/openfoodfacts-dart

@bhattabhi013
Copy link
Contributor

Yeah sure, please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing - Text fields ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers help wanted Extra attention is needed 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. 🎯 P1
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants