Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hatchstyle to hatch and new properties #59

Open
ebocher opened this issue Jul 10, 2024 · 2 comments
Open

Rename hatchstyle to hatch and new properties #59

ebocher opened this issue Jul 10, 2024 · 2 comments
Assignees
@maxcollombin
Labels
2024-07 Sprint

Comments

@ebocher
Copy link
Collaborator

ebocher commented Jul 10, 2024 •
edited
Loading

HatchStyle is available in core part 1. It must be renamed to hatch.

The new properties are described here : #24
@ebocher ebocher changed the title Remove hatchfill Remove hatchstyle Jul 10, 2024
@ebocher ebocher changed the title Remove hatchstyle Rename hatchstyle to hatch and new properties Jul 10, 2024
@maxcollombin
Copy link
Collaborator

In fact, we should rather delete the following comment in Part 1: Core

TODO: Change the model to allow a full definition with 1 or 2 hatching line direction, spacing and thickness.

and define the direction, spacing and thickness in Part 2/ Advanced Stroke and Fills

@ebocher ebocher mentioned this issue Jul 11, 2024
Merged
@ebocher
Copy link
Collaborator Author

ebocher commented Jul 11, 2024 •
edited
Loading

Define default values : angle (45°), width (1 px) , distance

@ghobona ghobona mentioned this issue Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxcollombin maxcollombin

Labels
2024-07 Sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebocher @maxcollombin