-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PVGeo: an open-source Python package for geoscientific visualization in VTK and ParaView #1451
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @gassmoeller, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@whedon generate pdf from branch joss-patch-figures |
|
@whedon generate pdf from branch joss-patch-figures-2 |
|
👋 Hi @gassmoeller @Leguark just checking in to see how the review is going. Please let me know if you have any questions about the process. And please remember to include |
Hi @leouieda and @banesullivan sorry for the delay. First of all, thank you for the authors for the great work on this library. After couple of years dealing myself with vtk what you have done here is going to facilitate enormously how visualize geodata in 3D.
In short, the library has already solid foundations to keep building functionality on top. I did not find any of the joos criteria missing. Therefore, I recommend the publication of this library and I am looking forward the future developments of this library and its integration with the rest of open geoscientific tools on the following months. |
Hi @leouieda and @banesullivan, I apologize for the slow process, I was at a developer meeting for one of my projects last week. I will finish the review until early next week. |
@banesullivan: I am not sure if it matters, but this issue still lists version 1.2.3 as the one for review, while you mentioned in #1384 that you would like to submit 2.0.0 for review. We should probably change the version in this issue. |
Dear @leouieda and @banesullivan I have now finished my review of PVGeo and the accompanying publication in JOSS and can fully recommend its publication. I have verified that the software works as described and I am convinced that it addresses an important need for Geoscientists that can be well extended to more applications in the future. The repository structure is logical and follows best practices and the documentation allows users to understand its purpose and integrate it into their own workflow. The software follows best practices regarding testing, coding, and distribution. The JOSS manuscript clearly describes the need for and application of the software and references relevant projects and publications. I have opened a minor issue that I would like to see addressed to make it simpler for new users to contribute to the development (see OpenGeoVis/PVGeo#49), and this review issue should be updated to reflect the authors request to submit version 2.0.0 instead of 1.2.3, but otherwise I recommend this paper for timely publication. Sincerely, |
Hi @Leguark and @gassmoeller, thank you for the speedy reviews! I have been traveling lately and went offline for about a week so I'm happy to address any issues now.
Thanks for the suggestion, @gassmoeller. I just updated PVGeo's readme to address this.
Ah yes, version 2.0.0 (actually 2.0.1 for when I tag and archive the repo for the submission) |
Hi @leouieda - I'd like to make sure this hasn't fallen off the radar. Could we make a list of the remaining action items? |
@banesullivan sorry, it did fall off the radar for a while. Thanks for the reminder 🙂 @gassmoeller and @Leguark thank you for the reviews! Regarding the version number, it's OK that there is a newer release. We'll update the version number here when it's time for publication. I see that you two still have unchecked items in your checklists. Is there anything that still needs to be addressed for those items? If not, please check them so we can move forward. |
No, I am simply not able to edit the first message for some reason but you can consider all checked |
I was just waiting for your confirmation about the version number. Everything ready from my side. |
@Leguark seems like Whedon un-assigned you temporarily from the issue for some reason. I've gone ahead and checked your boxes. @gassmoeller thanks for the confirmation! |
@whedon check references |
|
👋 @openjournals/joss-eics I'm happy to say that this contribution is ready for publication! @banesullivan congratulations on the acceptance 🎊 @Leguark @gassmoeller thank you very much for your reviews! We appreciate your time and dedication. If you wish to be called upon for future reviews, please feel free to sign up to our reviewer pool at https://joss.theoj.org/reviewer-signup.html |
Hi @banesullivan, I'm about to look over the paper to do some last checks, but first, can you please clean up the Zenodo archive metadata? The list of authors should match that of the paper, and right now you have a few extra people listed. |
Hi @kyleniemeyer, I just updated the Zenodo archive's meta data |
@banesullivan I just submitted a small PR that fixes a few citation commands in the paper, could you merge that? OpenGeoVis/PVGeo#52 Also, is there a better reference for VTK.js? At minimum, some names or a group should be included as the author. I'm also wondering if they have a preferred citation. |
@whedon generate pdf |
|
I'm not sure if there is another reference for VTK.js. Considering the VTK.js project's README states:
And points to the VTK Textbook reference that we currently have, maybe it would be fine to use the VTK reference? |
It's good to cite software directly, in addition to a published work. So perhaps in the text, when you mention VTK.js, you can cite the textbook in addition to the VTK.js software. For the software citation, perhaps add |
@whedon generate pdf |
|
@whedon generate pdf |
|
Ok, great! |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#804 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#804, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@banesullivan congratulations on your submission's publication in JOSS! Thanks to @gassmoeller and @Leguark for reviewing and @leouieda for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @banesullivan (C. Bane Sullivan)
Repository: https://github.com/OpenGeoVis/PVGeo
Version: v2.0.1
Editor: @leouieda
Reviewer: @gassmoeller, @Leguark
Archive: 10.5281/zenodo.3261820
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gassmoeller & @Leguark, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @leouieda know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @gassmoeller
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @Leguark
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: