Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema charter request to review #1056

Closed
2 of 4 tasks
Relequestual opened this issue Apr 17, 2023 · 7 comments
Closed
2 of 4 tasks

JSON Schema charter request to review #1056

Relequestual opened this issue Apr 17, 2023 · 7 comments
Labels
cross-project-council-agenda onboarding tracking onboarding for new/incubating projects

Comments

@Relequestual
Copy link
Contributor

Relequestual commented Apr 17, 2023

Having undergone a number of revisions based on feedback, I present the first JSON Schema charter, looking for your feedback and approval, as required by the OpenJS Foundation.

json-schema-org/community#325

I have requested review on the PR from the five individuals which will form the initial TSC with myself as chair.
We have had three approvals on the PR, and one request for changes, which is now resolved and waiting for re-review.

For timley responses, you can find me on slack. I may be somewhat slow to reply to direct comments here, although I'm making a note to check back on a regular basis.


Requirements:

The request is approved when:

  • There are no outstanding objections
  • There are two or more approvals by voting CPC members
  • The board has been consulted in the case of substantial changes
  • The issue has been open for at least 14 days
  • There are no outstanding objections
  • There are two or more approvals by voting CPC members
  • The board has been consulted in the case of substantial changes
  • The issue has been open for at least 14 days

Update 2023-08-09

We have undergone several rounds of feedback and revision, and based on the individual CPC reviews, I believe we are ready for formal review from the CPC.

I guess this should reset the 14 day timer, per requirements.

@tobie
Copy link
Contributor

tobie commented Apr 18, 2023

Congrats on reaching this important milestone! I’ll block time to make comments before the next CPC meeting.

@joesepi
Copy link
Member

joesepi commented Apr 19, 2023

I know a lot of work has gone into this @Relequestual and its exciting that it is nearly completed. Congratulations!

Let me ask just to be sure: there is one checkbox left in the description

Require all initial TSC members to review and approve of the PR

Has this been achieved? If not, it would seem premature for the CPC to approve. Just let us know. I'm happy to review it!

@tobie
Copy link
Contributor

tobie commented Apr 21, 2023

Alright, did a full review this morning. I recommend at least addressing the overarching issue of separation between policy (belongs in the charter) and process (implementation, belongs in dedicated docs that don't need CPC review) before moving forward with the CPC review.

@Relequestual
Copy link
Contributor Author

Relequestual commented Apr 21, 2023

I know a lot of work has gone into this @Relequestual and its exciting that it is nearly completed. Congratulations!

Thank you!

Let me ask just to be sure: there is one checkbox left in the description

Require all initial TSC members to review and approve of the PR

Has this been achieved? If not, it would seem premature for the CPC to approve. Just let us know. I'm happy to review it!

It has not, but we are presuming that it will be without any major changes.
Although, with @tobie's feedback, it looks like I'll be doing some work to move chunks out into a different document.

So, I'll remove the agenda label and mark it blocked, pending updates 🙏.

I don't think there will be any major changes now (just removals and shuffling), so I'm still open and looking for feedback!

@tobie, thank you for your review and feedback. Much appreciated. Working on a revision.

@mcollina
Copy link
Member

Added some feedbacks.

@Relequestual
Copy link
Contributor Author

The associated JSON Schema charter PR is now ready for re-review.
See json-schema-org/community#325 (comment) for comments.

@Relequestual
Copy link
Contributor Author

We have undergone several rounds of feedback and revision, and based on the individual CPC reviews, I believe we are ready for formal review from the CPC.

I've also edited the opening post to include this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-project-council-agenda onboarding tracking onboarding for new/incubating projects
Projects
None yet
Development

No branches or pull requests

4 participants