Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSPEC-3986: Week Year ("YYYY") should not be used for date formatting #58

Closed
yeikel opened this issue Apr 2, 2022 · 7 comments · Fixed by #129
Closed

RSPEC-3986: Week Year ("YYYY") should not be used for date formatting #58

yeikel opened this issue Apr 2, 2022 · 7 comments · Fixed by #129
Assignees
Labels
good first issue Good for newcomers recipe

Comments

@yeikel
Copy link
Contributor

yeikel commented Apr 2, 2022

Source : https://rules.sonarsource.com/java/RSPEC-3986/

@tkvangorder tkvangorder added enhancement New feature or request good first issue Good for newcomers labels Apr 4, 2022
@tkvangorder
Copy link
Contributor

tkvangorder commented Apr 4, 2022

For those contributors that are new OpenRewrite, please note that there are two additional things to be added to the cleanup recipes:

Override the time estimate for the issue (per occurrence)

    @Override
    public @Nullable Duration getEstimatedEffortPerOccurrence() {
        return Duration.ofMinutes(n);
    }

Make sure to label the recipe with the RSPEC number:

    @Override
    public Set<String> getTags() {
        return Collections.singleton("RSPEC-3986");
    }

@mccartney
Copy link
Contributor

The above link to Sonar is broken. https://rules.sonarsource.com/java/RSPEC-3986/ is the right one.

@tkvangorder
Copy link
Contributor

@mccartney
I have fixed the link in the initially comment, thanks for reporting

@vishalsingh2972
Copy link

@yeikel could you assign this to me!

@yeikel
Copy link
Contributor Author

yeikel commented Apr 12, 2023

@timtebeek Can help here as I don't have access

@timtebeek
Copy link
Contributor

Assigned just now; much appreciated!

@timtebeek timtebeek transferred this issue from openrewrite/rewrite May 1, 2023
@timtebeek
Copy link
Contributor

Hope you don't mind I unassigned you @vishalsingh2972
I want to open this issue back up again to anyone to pick up.
Feel free to open up a draft pull request if you'd like to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers recipe
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants