From 0bff5aa448bdfd94956aa602b74a3f44099facd1 Mon Sep 17 00:00:00 2001
From: Jarrad Raumati <jarrad.raumati@gmail.com>
Date: Wed, 13 Sep 2023 00:05:02 +1200
Subject: [PATCH] fix(wizards/foundation): Added missing DAI bTypes (#1320)

* Added missing DAI bTypes from IEC 61850-6 ed. 2.1
* Updated test snapshots to include added bTypes
* Octet assumed to be no zero padding, no space hexadecimal string value
---
 src/wizards/foundation/dai-field-type.ts      | 10 ++++
 src/wizards/foundation/enums.ts               |  3 ++
 .../bda-wizarding-editing.test.snap.js        | 54 +++++++++++++++++++
 .../da-wizarding-editing.test.snap.js         | 54 +++++++++++++++++++
 .../__snapshots__/abstractda.test.snap.js     | 24 +++++++++
 5 files changed, 145 insertions(+)

diff --git a/src/wizards/foundation/dai-field-type.ts b/src/wizards/foundation/dai-field-type.ts
index 0933c9e62..27470ba5c 100644
--- a/src/wizards/foundation/dai-field-type.ts
+++ b/src/wizards/foundation/dai-field-type.ts
@@ -38,6 +38,11 @@ const daiFieldTypes = [
   'VisString65',
   'VisString129',
   'VisString255',
+  'ObjRef',
+  'Currency',
+  'Octet64',
+  'Octet6',
+  'Octet16',
 ] as const;
 export type DaiFieldTypes = typeof daiFieldTypes[number];
 const emptyIfNull = <T>(item: T | null, value: string): string => {
@@ -65,6 +70,11 @@ export function getCustomField(): Record<DaiFieldTypes, CustomField> {
     VisString65: stringField('VisString65', 65),
     VisString129: stringField('VisString129', 129),
     VisString255: stringField('VisString255', 255),
+    ObjRef: stringField('VisString129', 129),
+    Currency: stringField('Currency', 3),
+    Octet64: stringField('Octet64', 64 * 2),
+    Octet6: stringField('Octet6', 6 * 2),
+    Octet16: stringField('Octet16', 16 * 2),
   };
 
   function booleanField(): CustomField {
diff --git a/src/wizards/foundation/enums.ts b/src/wizards/foundation/enums.ts
index be6002bf8..b6a23954a 100644
--- a/src/wizards/foundation/enums.ts
+++ b/src/wizards/foundation/enums.ts
@@ -49,7 +49,10 @@ export const predefinedBasicTypeEnum = [
   'TrgOps',
   'OptFlds',
   'SvOptFlds',
+  'LogOptFlds',
   'EntryID',
+  'Octet6',
+  'Octet16',
 ];
 
 export const valKindEnum = ['Spec', 'Conf', 'RO', 'Set'];
diff --git a/test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js b/test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js
index f227656fd..aad0783d3 100644
--- a/test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js
+++ b/test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js
@@ -366,6 +366,15 @@ snapshots["BDA wizarding editing integration defines a editBDaWizard to edit an
       >
         SvOptFlds
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="LogOptFlds"
+      >
+        LogOptFlds
+      </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
@@ -375,6 +384,24 @@ snapshots["BDA wizarding editing integration defines a editBDaWizard to edit an
       >
         EntryID
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet6"
+      >
+        Octet6
+      </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet16"
+      >
+        Octet16
+      </mwc-list-item>
     </wizard-select>
     <wizard-select
       fixedmenuposition=""
@@ -967,6 +994,15 @@ snapshots["BDA wizarding editing integration defines a createBDaWizard to create
       >
         SvOptFlds
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="LogOptFlds"
+      >
+        LogOptFlds
+      </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
@@ -976,6 +1012,24 @@ snapshots["BDA wizarding editing integration defines a createBDaWizard to create
       >
         EntryID
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet6"
+      >
+        Octet6
+      </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet16"
+      >
+        Octet16
+      </mwc-list-item>
     </wizard-select>
     <wizard-select
       fixedmenuposition=""
diff --git a/test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js b/test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js
index 386faa3cd..9047d8601 100644
--- a/test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js
+++ b/test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js
@@ -366,6 +366,15 @@ snapshots["DA wizarding editing integration defines a editDaWizard to edit an ex
       >
         SvOptFlds
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="LogOptFlds"
+      >
+        LogOptFlds
+      </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
@@ -375,6 +384,24 @@ snapshots["DA wizarding editing integration defines a editDaWizard to edit an ex
       >
         EntryID
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet6"
+      >
+        Octet6
+      </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet16"
+      >
+        Octet16
+      </mwc-list-item>
     </wizard-select>
     <wizard-select
       fixedmenuposition=""
@@ -1156,6 +1183,15 @@ snapshots["DA wizarding editing integration defines a createDaWizard to create a
       >
         SvOptFlds
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="LogOptFlds"
+      >
+        LogOptFlds
+      </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
@@ -1165,6 +1201,24 @@ snapshots["DA wizarding editing integration defines a createDaWizard to create a
       >
         EntryID
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet6"
+      >
+        Octet6
+      </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        role="option"
+        tabindex="-1"
+        value="Octet16"
+      >
+        Octet16
+      </mwc-list-item>
     </wizard-select>
     <wizard-select
       fixedmenuposition=""
diff --git a/test/unit/wizards/__snapshots__/abstractda.test.snap.js b/test/unit/wizards/__snapshots__/abstractda.test.snap.js
index eaaad405e..d76371c82 100644
--- a/test/unit/wizards/__snapshots__/abstractda.test.snap.js
+++ b/test/unit/wizards/__snapshots__/abstractda.test.snap.js
@@ -305,6 +305,14 @@ snapshots["abstractda wizards renderWizard looks like the latest snapshot"] =
       >
         SvOptFlds
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        tabindex="-1"
+        value="LogOptFlds"
+      >
+        LogOptFlds
+      </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
@@ -313,6 +321,22 @@ snapshots["abstractda wizards renderWizard looks like the latest snapshot"] =
       >
         EntryID
       </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        tabindex="-1"
+        value="Octet6"
+      >
+        Octet6
+      </mwc-list-item>
+      <mwc-list-item
+        aria-disabled="false"
+        mwc-list-item=""
+        tabindex="-1"
+        value="Octet16"
+      >
+        Octet16
+      </mwc-list-item>
     </wizard-select>
     <wizard-select
       fixedmenuposition=""