Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D&D] Functional: validate export/import of saved objects #1885

Closed
joshuarrrr opened this issue Jul 12, 2022 · 3 comments
Closed

[D&D] Functional: validate export/import of saved objects #1885

joshuarrrr opened this issue Jul 12, 2022 · 3 comments

Comments

@joshuarrrr
Copy link
Member

No description provided.

@ashwin-pc
Copy link
Member

ashwin-pc commented Oct 18, 2022

@joshuarrrr What exactly do we need to test for this flow? I have as a part of the functional test flow, steps to seed saved object data for Vis Builder. Would that cover the import section of this test?

Also does this need to be a part of the vis builder functional test suite or Dashboards in general?

@joshuarrrr
Copy link
Member Author

After looking at this again, I'm not sure it's in scope? It's more about testing whether we correctly integrated with the saved object management plugin, so that some of its standard flows (such as importing/exporting via UI) work as expected.

But given the open issues around import/export, such as #1526 and #1723, I wonder if that work would be better done in a more comprehensive look at the saved object management behavior in general.

So I think I'd recommend just closing this issue, especially if we've manually validated that import/export through the UI works as expected.

@ashwin-pc
Copy link
Member

Closing this as per @joshuarrrr recommendation. Will need a comprehensive "saved object management" test flow thats separate from VisBuilder

@ashwin-pc ashwin-pc closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants