Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] De-couple and support to build win32 x64 #796

Closed
ananzh opened this issue Sep 13, 2021 · 1 comment
Closed

[Build] De-couple and support to build win32 x64 #796

ananzh opened this issue Sep 13, 2021 · 1 comment
Labels
build Build related additions or modifications technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ananzh
Copy link
Member

ananzh commented Sep 13, 2021

Is your feature request related to a problem? Please describe.

When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so.

A previous PR #795 has de-coupled the build process for linux. However, de-couple windows is a bit different. The node_download_info task downloads nodejs fromhttps://nodejs.org/dist/v${version}/win-x64/node.exe for windows which is not able to be executed in every platform (for example, linux). Windows doesn't have a tarball like linux.

Describe the solution you'd like
The reason we need to download and unzip the tarball from https://nodejs.org/dist/v${version}/win-x64/node.exe is to get nodejs license info and then add it to our docs. This license info is the same for both windows and linux. An easy way is to also download and unzip linux-x64 tar for windows and use info from there.

Describe alternatives you've considered
@ananzh ananzh added the build Build related additions or modifications label Sep 13, 2021
@ananzh ananzh self-assigned this Sep 13, 2021
@ananzh ananzh removed their assignment Sep 23, 2021
@kavilla kavilla mentioned this issue Apr 26, 2022
Closed
@tmarkley tmarkley added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label May 25, 2022
@joshuarrrr joshuarrrr mentioned this issue Oct 10, 2022
Closed
@AMoo-Miki
Copy link
Collaborator

This is solved with #2601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Build related additions or modifications technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AMoo-Miki @tmarkley @ananzh