Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query Insights] Add user info in top queries results #12740

Open
ansjcy opened this issue Mar 18, 2024 · 2 comments
Open

[Query Insights] Add user info in top queries results #12740

ansjcy opened this issue Mar 18, 2024 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights

Comments

@ansjcy
Copy link
Member

ansjcy commented Mar 18, 2024

Is your feature request related to a problem? Please describe

One of the top ask from the query insights users are the ability to identify users that submitted those heavy queries. We have made some experiments in #12529 to read from the thread environment context but after the discussion with the community, we learned that might not be the best solution for getting user related info.

We need to again carefully review what should be the best way to add user related information into top queries - Let's check the Identity service to see what are the gaps to get user info from there.

Describe the solution you'd like

Utilize identity service to add user related info into top queries results.

Related component

Search:Query Insights

Describe alternatives you've considered

No response

Additional context

No response

@ansjcy ansjcy added enhancement Enhancement or improvement to existing feature or request untriaged Search:Query Insights and removed untriaged labels Mar 18, 2024
@ansjcy
Copy link
Member Author

ansjcy commented Mar 28, 2024

So the gap here is, we need to correctly implement different Subject (and other related) classes for different auth methods in security plugin, and also the getSubject function in security plugin to be able to get identity info while using different auth methods, so that we can correctly retrieve the user related information in the query insights plugin. We might need some help from the security team about this.

@peternied Please let me know if this make sense, we can discuss further if we want to prioritize this later :)

@ansjcy
Copy link
Member Author

ansjcy commented Jun 10, 2024

Part of the work is done as part of #13374, in which we provided certain abilities to send customized labels in a search query as part of the X-Opaque-Id header, and top n queries service will surface that information.

We still need to continue the work on

To introduce a separate header dedicated for labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights
Projects
Status: Todo
Status: Later (6 months plus)
Development

No branches or pull requests

1 participant