Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Changelog verifier should fail if CHANGELOG-3.0.MD is modified and a backport label is applied. #15155

Closed
jed326 opened this issue Aug 7, 2024 · 2 comments · Fixed by #15214
Closed

[Feature Request] Changelog verifier should fail if CHANGELOG-3.0.MD is modified and a backport label is applied. #15155

jed326 opened this issue Aug 7, 2024 · 2 comments · Fixed by #15214
Assignees
@jed326
Labels
Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers untriaged

Comments

@jed326
Copy link
Collaborator

jed326 commented Aug 7, 2024

Is your feature request related to a problem? Please describe

Had an issue earlier where a changelog entry was added to 3.0 and also backported to 2.x: #15150

This means the changelog for 3.0 was wrong and will probably break auto backport for other PRs. We should be able to add an automated check to the changelog verifier to catch this case.

Describe the solution you'd like

Suggested by @andrross here: #15150 (comment)

Related component

Build

Describe alternatives you've considered

No response

Additional context

No response
@jed326 jed326 added enhancement Enhancement or improvement to existing feature or request untriaged labels Aug 7, 2024
@jed326 jed326 self-assigned this Aug 7, 2024
@github-actions github-actions bot added the Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. label Aug 7, 2024
@jed326 jed326 added good first issue Good for newcomers Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. and removed Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Aug 7, 2024
@jed326
Copy link
Collaborator Author

jed326 commented Aug 8, 2024

Self assigning for now but if anyone else is interested in picking this up feel free

@sandeshkr419
Copy link
Contributor

sandeshkr419 commented Aug 8, 2024 •
edited
Loading

Thanks for taking this up @jed326.
To add on to the discussion #15150 (comment) - Let's also enforce in changelog verifier CI that >breaking label and backport-2.x label do not also exist together - this bubbles up that no breaking changes go to 2.x as well.

This was referenced Aug 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jed326 jed326

Labels
Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers untriaged
Projects
None yet
Milestone
No milestone
2 participants
@sandeshkr419 @jed326