Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace or remove the "slave" terminology used in a test data #1556

Closed
tlfeng opened this issue Nov 16, 2021 · 2 comments
Closed

Replace or remove the "slave" terminology used in a test data #1556

tlfeng opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test v1.3.0

Comments

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 16, 2021

Is your feature request related to a problem? Please describe.
Replace or remove the non-inclusive terminology from the code base.

Describe the solution you'd like
There is only 1 usage in the code base that can be replaced or removed, which is a test data:

Document from Elatic that explains the fields in the template: https://www.elastic.co/guide/en/beats/metricbeat/7.10/exported-fields-redis.html

Describe alternatives you've considered
None.

Additional context
Related issue #472

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test v1.3.0 labels Nov 16, 2021
@Rishikesh1159
Copy link
Member

I will look into this.

@kartg
Copy link
Member

kartg commented Dec 1, 2021

Change merged, backport pending. Leaving this issue open until that is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test v1.3.0
Projects
None yet
Development

No branches or pull requests

3 participants