Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Explicit maven group setting for pluginZip broke #4756

Closed
prudhvigodithi opened this issue Oct 12, 2022 · 1 comment
Closed

[BUG] Explicit maven group setting for pluginZip broke #4756

prudhvigodithi opened this issue Oct 12, 2022 · 1 comment

Comments

@prudhvigodithi
Copy link
Contributor

Describe the bug
Coming from #4733 (comment), with PR #4733 merge, the pluginZip functionality to choose the groupID org.opensearch.plugin broke.

  1. The default groupID is not getting applied as org.opensearch.plugin.
  2. If we add specifically the group = org.opensearch.plugin not only the zips but the jars are also being pushed to org.opensearch.plugin

To Reproduce

  1. /build.sh manifests/2.4.0/opensearch-2.4.0.yml --component OpenSearch
  2. /build.sh manifests/2.4.0/opensearch-2.4.0.yml --component job-scheduler

Expected behavior
When added group org.opensearch.plugin to pluginZip the other publications should not use this and vice versa.
The zips should be part of org.opensearch.plugin and jars should be part of org.opensearch group.

Additional context
Add any other context about the problem here.

@prudhvigodithi prudhvigodithi added bug Something isn't working untriaged labels Oct 12, 2022
@prudhvigodithi prudhvigodithi changed the title [BUG] Explicit maven group setting does not work with pluginZip [BUG] Explicit maven group setting for pluginZip broke Oct 12, 2022
@reta
Copy link
Collaborator

reta commented Oct 12, 2022

Ok, together with @prudhvigodithi we figured out, there is confusion regarding group and groupId settings, the pluginZip must set groupId (not group), otherwise it affects project's wide setting and overrides all publications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants