-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Searchable Snapshot] Prevent deletion of snapshots that are backing searchable snapshot indexes #4967
Comments
I am working on this task. |
Can we look into keeping a reference count of active backup in progress. If the count is non-zero both command line and Ux can prevent it from deletion. |
@opencmit1 A searchable snapshot is a new feature under development. You can follow the progress in #2919 A searchable snapshot index uses a snapshot instance as its source of data and fetches the data on demand at search time. Deleting that snapshot would render the index inoperable, hence the desire to add this protection. |
@nandi-github Can you explain what "active backup in progress" means here? |
@andrross I think what @nandi-github is referring to is the same as what we discussed earlier: If there is any index backed up by the remote snapshot, deny deletion using a reference count for such backed up indices. Eventual consistency in some of the repository implementations might lead to this approach being incorrect. |
Do you need further clarification or it is good for now ? |
The system is missing the protection to prevent a snapshot from being deleted if it is currently backing a searchable snapshot index. The desired behavior is that a user should delete all such indexes before deleting the snapshot is allowed.
The text was updated successfully, but these errors were encountered: