Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Searchable Snapshot] Prevent deletion of snapshots that are backing searchable snapshot indexes #4967

Closed
Tracked by #5087
andrross opened this issue Oct 28, 2022 · 6 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search

Comments

@andrross
Copy link
Member

The system is missing the protection to prevent a snapshot from being deleted if it is currently backing a searchable snapshot index. The desired behavior is that a user should delete all such indexes before deleting the snapshot is allowed.

@andrross andrross added enhancement Enhancement or improvement to existing feature or request Indexing & Search labels Oct 28, 2022
@Vishalks
Copy link
Contributor

Vishalks commented Nov 1, 2022

I am working on this task.

@nandi-github
Copy link

Can we look into keeping a reference count of active backup in progress. If the count is non-zero both command line and Ux can prevent it from deletion.

@andrross
Copy link
Member Author

andrross commented Nov 3, 2022

@opencmit1 A searchable snapshot is a new feature under development. You can follow the progress in #2919 A searchable snapshot index uses a snapshot instance as its source of data and fetches the data on demand at search time. Deleting that snapshot would render the index inoperable, hence the desire to add this protection.

@andrross
Copy link
Member Author

andrross commented Nov 3, 2022

Can we look into keeping a reference count of active backup in progress. If the count is non-zero both command line and Ux can prevent it from deletion.

@nandi-github Can you explain what "active backup in progress" means here?

@Vishalks
Copy link
Contributor

Vishalks commented Nov 3, 2022

@andrross I think what @nandi-github is referring to is the same as what we discussed earlier: If there is any index backed up by the remote snapshot, deny deletion using a reference count for such backed up indices. Eventual consistency in some of the repository implementations might lead to this approach being incorrect.

@nandi-github
Copy link

Do you need further clarification or it is good for now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search
Projects
None yet
Development

No branches or pull requests

5 participants
@andrross @Vishalks @nandi-github @xuezhou25 and others