Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Response Processor #6715

Closed
Tracked by #6710
macohen opened this issue Mar 16, 2023 · 4 comments
Closed
Tracked by #6710

Conditional Response Processor #6715

macohen opened this issue Mar 16, 2023 · 4 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Relevance Search Search query, autocomplete ...etc

Comments

@macohen
Copy link
Contributor

macohen commented Mar 16, 2023

As a user of search pipelines, I want to be able to insert conditional checks on the search response into my pipeline to inform what the pipeline should execute next.

@macohen macohen added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 16, 2023
@minalsha minalsha added the Search Search query, autocomplete ...etc label Mar 16, 2023
@minalsha
Copy link
Contributor

@macohen can this issue be moved to search-processor?

@msfroh msfroh removed the untriaged label Mar 16, 2023
@macohen
Copy link
Contributor Author

macohen commented Jul 26, 2023

@noCharger commented in person that this could just be a specific ScriptResponseProcessor: #6713. If that's the case, I think putting effort into the scriptresponseprocessor and then seeing if we should have a specific processor that abstracts the choice made may be the right thing. Next step would be some info about how ScriptResponseProcessor could work for this case...

cc: @msfroh, @mingshl, @sejli

@msfroh
Copy link
Collaborator

msfroh commented Jul 27, 2023

If we want this to be consistent with ingest pipelines (which should be the guiding principle IMO), this wouldn't be a specific processor that users would add to their pipeline, but rather it would be a wrapper around another processor.

See e.g. https://www.elastic.co/guide/en/elasticsearch/reference/7.10/ingest-conditionals.html

@macohen
Copy link
Contributor Author

macohen commented Jan 10, 2024

duplicates #11782

@macohen macohen closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Relevance Search Search query, autocomplete ...etc
Projects
Status: Done
Development

No branches or pull requests

4 participants