Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows support for signing artifacts #1430

Closed
4 tasks done
Tracked by #33
abhinavGupta16 opened this issue Jan 6, 2022 · 3 comments
Closed
4 tasks done
Tracked by #33

Add windows support for signing artifacts #1430

abhinavGupta16 opened this issue Jan 6, 2022 · 3 comments
Assignees
@zelinh
Labels
enhancement New Enhancement windows

Comments

@abhinavGupta16
Copy link
Contributor

abhinavGupta16 commented Jan 6, 2022 •
edited by zelinh
Loading

Is your feature request related to a problem? Please describe

Currently, the signer.py only supports signing for linux clients for PGP. We need to extend this for windows as well.

We also need to extend the signArtifacts job for standalone components to be able to sign windows artifacts.

Describe the solution you'd like

Pass windows as a parameter and signer can sign and verify windows artifacts.

Acceptance Criteria

  • I am able to sign and verify windows artifacts using sign.sh.
  • Added test cases to test the workflow
  • Updated the signArtifacts job for standalone components for windows
  • Updated the test cases for signArtifacts job for standalone components for windows

Describe alternatives you've considered

No response

Additional context

No response
@abhinavGupta16 abhinavGupta16 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 6, 2022
@dblock dblock changed the title Add support for windows to signer.py Add windows support for signing artifacts Jan 11, 2022
@dblock dblock removed the untriaged Issues that have not yet been triaged label Jan 11, 2022
@dblock dblock mentioned this issue Jan 11, 2022
Closed
19 tasks
@dblock dblock added the windows label Jan 11, 2022
@bbarani
Copy link
Member

bbarani commented Jun 6, 2022

@zelinh Can you please update this issue with the current status?

@zelinh zelinh mentioned this issue Jun 6, 2022
Merged
@zelinh
Copy link
Member

zelinh commented Jun 6, 2022

New PR #2156 was raised. Now with that PR, we should be able to sign windows artifacts with the sign scripts we have and also sign by using jenkins signArtifacts library.

@bbarani
Copy link
Member

bbarani commented Jul 6, 2022

Closing this issue as we have implemented the signing support for Windows artifacts

@bbarani bbarani closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zelinh zelinh

Labels
enhancement New Enhancement windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dblock @abhinavGupta16 @bbarani @zelinh