Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] What are System Integrators? #3447

Closed
cwperks opened this issue Oct 3, 2023 · 2 comments
Closed

[Question] What are System Integrators? #3447

cwperks opened this issue Oct 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cwperks
Copy link
Member

cwperks commented Oct 3, 2023

Related to: opensearch-project/OpenSearch#10260

There is a suite of tests called SystemIntegratorTests that uses a UserInjectorPlugin that installs a custom HttpTransport called org.opensearch.security.http.UserInjectingServerTransport.

The purpose of this transport is to wrap a RestHandler and inject a user into the threadcontext if a specific HttpHeader is present.

This plugin works with the SecurityPlugin installed (albeit the Security plugin is not used as an HttpTransport so no SSL is configured) and can inject a user into the ThreadContext that get's picked up by the SecurityPlugin.

In #3418, the SystemIntegratorTests started failing because it was configured to use the HttpTransport from the UserInjectorPlugin instead of the HttpTransport from the SecurityPlugin.

In order to facilitate moving authn to a step in the netty pipeline before decompression, then the security plugin must be the configured HttpTransport and no other plugin.

@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 3, 2023
@stephen-crawford
Copy link
Collaborator

stephen-crawford commented Oct 9, 2023

[Triage] Hi @cwperks, sounds like you got an answer to this question. Please feel free to amend this information to the architecture guide and then close this issue.

@stephen-crawford stephen-crawford removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 9, 2023
@stephen-crawford
Copy link
Collaborator

Closing this issue. Thank you for your investigation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants