From 307b8b54768bc4ce950b22a71155a1d4e81b5d9f Mon Sep 17 00:00:00 2001 From: Michal Fojtik Date: Tue, 2 May 2017 16:44:14 +0200 Subject: [PATCH] deploy: set background propagation policy for old deployment cleanup --- pkg/deploy/controller/deploymentconfig/controller.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/deploy/controller/deploymentconfig/controller.go b/pkg/deploy/controller/deploymentconfig/controller.go index eef93595c24d..b016157e2882 100644 --- a/pkg/deploy/controller/deploymentconfig/controller.go +++ b/pkg/deploy/controller/deploymentconfig/controller.go @@ -7,6 +7,7 @@ import ( "github.com/golang/glog" kapierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/runtime" kutilerrors "k8s.io/apimachinery/pkg/util/errors" @@ -435,7 +436,9 @@ func (c *DeploymentConfigController) cleanupOldDeployments(existingDeployments [ continue } - err := c.rn.ReplicationControllers(deployment.Namespace).Delete(deployment.Name, nil) + err := c.rn.ReplicationControllers(deployment.Namespace).Delete(deployment.Name, metav1.DeleteOptions{ + PropagationPolicy: &metav1.DeletePropagationBackground, + }) if err != nil && !kapierrors.IsNotFound(err) { deletionErrors = append(deletionErrors, err) }