Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image size no longer in dockerImageMetadata #10592

Closed
spadgett opened this issue Aug 23, 2016 · 7 comments
Closed

Image size no longer in dockerImageMetadata #10592

spadgett opened this issue Aug 23, 2016 · 7 comments
Assignees
@legionus
Labels
component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@spadgett
Copy link
Member

The web console will show the image size in the pod template when it's defined in the dockerImageMetadata for the ImageStreamImage. This worked in 1.2:

screen_shot_2016-08-23_at_10_15_19_am

It's no longer working in 1.3:

screen shot 2016-08-23 at 10 15 42 am

It's not working because Size is now missing from the image metadata. Is this expected? The image is one that I built using an s2i builder, pushed to an image stream in the same namespace.

@mfojtik @miminar @liggitt @jwforres
@spadgett
Copy link
Member Author

ImageStreamImage JSON:

{
  "kind": "ImageStreamImage",
  "apiVersion": "v1",
  "metadata": {
    "name": "origin-ruby-sample@7ffccfa",
    "namespace": "hello",
    "selfLink": "/oapi/v1/namespaces/hello/imagestreamimages/origin-ruby-sample@7ffccfa",
    "creationTimestamp": null
  },
  "image": {
    "metadata": {
      "name": "sha256:7ffccfab24a4fc88f35d2c6d70f136b2a8922ea6ff96823c150ed94555c338c0",
      "uid": "5c9f3abc-63b2-11e6-98d2-080027893417",
      "resourceVersion": "94119",
      "creationTimestamp": "2016-08-16T13:07:19Z",
      "annotations": {
        "openshift.io/image.managed": "true"
      }
    },
    "dockerImageReference": "172.30.97.204:5000/hello/origin-ruby-sample@sha256:7ffccfab24a4fc88f35d2c6d70f136b2a8922ea6ff96823c150ed94555c338c0",
    "dockerImageMetadata": {
      "kind": "DockerImage",
      "apiVersion": "1.0",
      "Id": "73235c925379ec942f7998597df9d390f65d73e070d12445f3bc315165b4550a",
      "Parent": "62b8910a377a34bed514e7ac13a0aec72aa8726f0d0b7ba72d687baf18da48dc",
      "Created": "2016-08-16T13:04:39Z",
      "Container": "a3ff5af4477b2918f747ed1a37a77a4cf458487b9e2a7934a4d6fb0b8805d323",
      "ContainerConfig": {
        "Hostname": "ruby-sample-build-4-build",
        "User": "1001",
        "AttachStdout": true,
        "ExposedPorts": {
          "8080/tcp": {}
        },
        "OpenStdin": true,
        "StdinOnce": true,
        "Env": [
          "RACK_ENV=production",
          "OPENSHIFT_BUILD_NAME=ruby-sample-build-4",
          "OPENSHIFT_BUILD_NAMESPACE=hello",
          "OPENSHIFT_BUILD_SOURCE=https://github.com/openshift/ruby-hello-world.git",
          "EXAMPLE=sample-app",
          "PATH=/opt/app-root/src/bin:/opt/app-root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
          "STI_SCRIPTS_URL=image:///usr/libexec/s2i",
          "STI_SCRIPTS_PATH=/usr/libexec/s2i",
          "HOME=/opt/app-root/src",
          "BASH_ENV=/opt/app-root/etc/scl_enable",
          "ENV=/opt/app-root/etc/scl_enable",
          "PROMPT_COMMAND=. /opt/app-root/etc/scl_enable",
          "RUBY_VERSION=2.2"
        ],
        "Cmd": [
          "/bin/sh",
          "-c",
          "tar -C /tmp -xf - \u0026\u0026 /usr/libexec/s2i/assemble"
        ],
        "Image": "centos/ruby-22-centos7@sha256:8c6c4ff3ae64a90ab1535a7ff33e685c63b3d51f7915722292c12e5ccb8f0a7f",
        "WorkingDir": "/opt/app-root/src",
        "Entrypoint": [
          "container-entrypoint"
        ],
        "Labels": {
          "build-date": "20160729",
          "io.k8s.description": "Platform for building and running Ruby 2.2 applications",
          "io.k8s.display-name": "hello/ruby-sample-build-4:a1ceebfd",
          "io.openshift.build.commit.author": "Ben Parees \u003cbparees@users.noreply.github.com\u003e",
          "io.openshift.build.commit.date": "Tue Apr 5 10:06:50 2016 -0400",
          "io.openshift.build.commit.id": "e79d8870be808a7abb4ab304e94c8bee69d909c6",
          "io.openshift.build.commit.message": "Merge pull request #53 from danmcp/master",
          "io.openshift.build.commit.ref": "master",
          "io.openshift.build.image": "centos/ruby-22-centos7@sha256:8c6c4ff3ae64a90ab1535a7ff33e685c63b3d51f7915722292c12e5ccb8f0a7f",
          "io.openshift.build.source-location": "https://github.com/openshift/ruby-hello-world.git",
          "io.openshift.builder-base-version": "e178f1c",
          "io.openshift.builder-version": "9151afcd54e33189cc9e06dce911aae9a758d1e8",
          "io.openshift.expose-services": "8080:http",
          "io.openshift.s2i.scripts-url": "image:///usr/libexec/s2i",
          "io.openshift.tags": "builder,ruby,ruby22",
          "io.s2i.scripts-url": "image:///usr/libexec/s2i",
          "license": "GPLv2",
          "name": "CentOS Base Image",
          "vendor": "CentOS"
        }
      },
      "DockerVersion": "1.10.3",
      "Config": {
        "User": "1001",
        "ExposedPorts": {
          "8080/tcp": {}
        },
        "Env": [
          "RACK_ENV=production",
          "OPENSHIFT_BUILD_NAME=ruby-sample-build-4",
          "OPENSHIFT_BUILD_NAMESPACE=hello",
          "OPENSHIFT_BUILD_SOURCE=https://github.com/openshift/ruby-hello-world.git",
          "EXAMPLE=sample-app",
          "PATH=/opt/app-root/src/bin:/opt/app-root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
          "STI_SCRIPTS_URL=image:///usr/libexec/s2i",
          "STI_SCRIPTS_PATH=/usr/libexec/s2i",
          "HOME=/opt/app-root/src",
          "BASH_ENV=/opt/app-root/etc/scl_enable",
          "ENV=/opt/app-root/etc/scl_enable",
          "PROMPT_COMMAND=. /opt/app-root/etc/scl_enable",
          "RUBY_VERSION=2.2"
        ],
        "Cmd": [
          "/usr/libexec/s2i/run"
        ],
        "WorkingDir": "/opt/app-root/src",
        "Entrypoint": [
          "container-entrypoint"
        ],
        "Labels": {
          "build-date": "20160729",
          "io.k8s.description": "Platform for building and running Ruby 2.2 applications",
          "io.k8s.display-name": "hello/ruby-sample-build-4:a1ceebfd",
          "io.openshift.build.commit.author": "Ben Parees \u003cbparees@users.noreply.github.com\u003e",
          "io.openshift.build.commit.date": "Tue Apr 5 10:06:50 2016 -0400",
          "io.openshift.build.commit.id": "e79d8870be808a7abb4ab304e94c8bee69d909c6",
          "io.openshift.build.commit.message": "Merge pull request #53 from danmcp/master",
          "io.openshift.build.commit.ref": "master",
          "io.openshift.build.image": "centos/ruby-22-centos7@sha256:8c6c4ff3ae64a90ab1535a7ff33e685c63b3d51f7915722292c12e5ccb8f0a7f",
          "io.openshift.build.source-location": "https://github.com/openshift/ruby-hello-world.git",
          "io.openshift.builder-base-version": "e178f1c",
          "io.openshift.builder-version": "9151afcd54e33189cc9e06dce911aae9a758d1e8",
          "io.openshift.expose-services": "8080:http",
          "io.openshift.s2i.scripts-url": "image:///usr/libexec/s2i",
          "io.openshift.tags": "builder,ruby,ruby22",
          "io.s2i.scripts-url": "image:///usr/libexec/s2i",
          "license": "GPLv2",
          "name": "CentOS Base Image",
          "vendor": "CentOS"
        }
      },
      "Architecture": "amd64"
    },
    "dockerImageMetadataVersion": "1.0",
    "dockerImageLayers": [
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:3d8673bd162aafaf70e94029801a409fa3210363707ea1e7956b6f8ff9351cc8",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:9b49c3a38afb5b54ddeebb0fbdf7d06d48bd0e491d704e9569d5b15abab3e45c",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:6bbe0688da8096884bdcfe55e815185c7d754088d368f2f2beedf688a1c1bef5",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:0ee43bbdab122b7bb13a1949842e3dcc77a73498b0a1870968770c32b3f86f5b",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:14c5cd91b2e32bf78648e2fa64932986fd0bee98ab17460f5cd9cd1f132aea21",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:79f568858a2794029b45ee218128460ef75c3f264963472b3a6008ffdd65b437",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:623c5808bdf34e9d734900bf72097a32428b952a61f9a09adb2a1fde6ce5f9ee",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:c608fa33c8eae3523255828f548c188121848430ed3c71f17a08568fd0724149",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      },
      {
        "name": "sha256:c4ad1267317ed0bdc4ecae13ebc10ed964275f3bbbc8f3f0a28a425bcae3efe6",
        "size": 0,
        "mediaType": "application/vnd.docker.container.image.rootfs.diff+x-gtar"
      }
    ],
    "dockerImageManifestMediaType": "application/vnd.docker.distribution.manifest.v1+json"
  }
}

@mfojtik
Copy link
Contributor

mfojtik commented Aug 23, 2016

I think we talked about this with @legionus and @miminar that this is something we can't compute effectively, but I let @legionus explain what is behind this change and if there is a workaround or fix for this as @miminar is off this week.

@mfojtik mfojtik added kind/bug Categorizes issue or PR as related to a bug. priority/P2 component/imageregistry labels Aug 23, 2016
@legionus
Copy link
Contributor

Manifest in old format no longer contains information about the image size (#9115).

At the time when the image is imported, we compute its size. We do the same in docker-registry.

@spadgett How this image was created ?

@spadgett
Copy link
Member Author

From an s2i builder

@legionus
Copy link
Contributor

@spadgett I tried to reproduce this on the latest origin, I used origin-ruby-simple too. I can see image size.

Can you try to reproduce this on origin master ?

@spadgett
Copy link
Member Author

I am current on origin master as of yesterday, and I'm still seeing it :/

@spadgett
Copy link
Member Author

I'm no longer seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legionus legionus

Labels
component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfojtik @spadgett @legionus