Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map moving on mouse wheel click has stopped working #3612

Closed
edpop opened this issue Nov 24, 2016 · 4 comments
Closed

Map moving on mouse wheel click has stopped working #3612

edpop opened this issue Nov 24, 2016 · 4 comments
Labels
usability An issue with ease-of-use or design

Comments

@edpop
Copy link
Contributor

edpop commented Nov 24, 2016

Unlike v1.9.7, mouse wheel click has stopped working. It is necessary to draw ways.
I'm trying to find this change in the code...

@bhousel
Copy link
Member

bhousel commented Nov 24, 2016

Yes, unfortunately it's pretty much impossible to do blames/bisects between v1.9.x and v2.0.x code.

This might have been something that changed with the upgrade to d3 v4. Can you describe a bit more about what the issue is? I've never tried clicking the mousewheel, so I'm not really sure what the previous behavior was.

@edpop
Copy link
Contributor Author

edpop commented Nov 24, 2016

You could move the map by clicking on the mouse wheel, when you were at draw mode.

@bhousel bhousel added the usability An issue with ease-of-use or design label Nov 28, 2016
@bhousel
Copy link
Member

bhousel commented Dec 6, 2016

Hey @edpop I might have fixed this in 77b78a7.

The default d3 zoom event filter was doing something like event.button === 0 (left button only), and I adjusted it here to say event.button !== 2 (ignore right clicks).

When you get a chance, can you test in http://openstreetmap.us/iD/master and see if mouse wheel clicks are working again, and if so close this issue?

@edpop
Copy link
Contributor Author

edpop commented Dec 6, 2016

Thanks, it works very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants