Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping to and from roles in turn restrictions #4140

Closed
kreuzschnabel opened this issue Jul 10, 2017 · 1 comment
Closed

Keeping to and from roles in turn restrictions #4140

kreuzschnabel opened this issue Jul 10, 2017 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@kreuzschnabel
Copy link

kreuzschnabel commented Jul 10, 2017

Imagine a way on a primary road, call it w1, with two nodes on its ends, n1 and n2.

Some mappers tend to explicitly forbid U-turns on the ends of such ways by restriction=no_u_turn and the members

w1 as from
n1 as via
w1 as to

(and the same at the other end).

Now, whenever such a way is split using iD, say into w1 and w2 linked by the new node n3, it will put one of the parts in the to and the other into the from role:

w1 as from
n1 as via
w2 as to

This TR is technically no longer valid because the to-role is not connected to the via-role. However, this kind of restriction makes OsmAnd interpret the restriction as, „no_straight_on“ in the given order of from and to, ignoring the wrong via. We have had several routing misbehaviour because of that on primary roads in Germany in recent weeks.

My suggestion: Whenever a way is split which is linked to both "to" and "from" role in a TR, after the split the same way (which touches the "via" node) should be in "to" and "from" on order to preserve the TR.

@bhousel bhousel added the bug A bug - let's fix this! label Jul 10, 2017
@bhousel
Copy link
Member

bhousel commented Jul 10, 2017

Wow that sounds pretty bad, thanks for reporting this!

@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label Jul 10, 2017
@bhousel bhousel removed the priority A top priority issue that has a big impact or matter most to new mappers label Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants