Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing some office=* presets #4489

Closed
abdeldjalil09 opened this issue Oct 30, 2017 · 2 comments
Closed

missing some office=* presets #4489

abdeldjalil09 opened this issue Oct 30, 2017 · 2 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Oct 30, 2017

office=association --> https://wiki.openstreetmap.org/wiki/Tag:office=association
office=advertising_agency --> https://wiki.openstreetmap.org/wiki/Tag:office=advertising_agency
office=surveyor --> https://wiki.openstreetmap.org/wiki/Tag:office=surveyor

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest preset An issue with an OpenStreetMap preset or tag labels Oct 30, 2017
@Nmargolis
Copy link
Contributor

Hello! I submitted a PR for this (#4491)

While I was working on it, I noticed that several other office=* presets were missing as well (see below). Should there be a new issue for that or should I include them in the same PR? I'm a first time contributor so not sure what the process is.

Here are the other missing presets that are on the OSM Wiki:

  • adoption_agency
  • charity
  • energy_supplier
  • forestry
  • foundation
  • guide
  • logistics
  • moving_company
  • notary
  • private_investigator
  • quango
  • religion
  • tax
  • tax_advisor
  • travel_agent
  • water_utility

@abdeldjalil09
Copy link
Contributor Author

abdeldjalil09 commented Oct 31, 2017

@bhousel bhousel added wip Work in progress and removed wip Work in progress labels Oct 31, 2017
@bhousel bhousel closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants