Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Mapillary image is still being processed, street level panel shows stale image #4536

Closed
1ec5 opened this issue Nov 16, 2017 · 4 comments
Closed
Labels
streetlevel An issue with streetlevel photos

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Nov 16, 2017

This image is currently being processed by Mapillary, so if you click on it right around here, you get a thumbnail image (which I think is for the correct image) with oversized Mapillary branding overlays:

thumbnail

However, if you’ve already previously viewed a Mapillary image that has been processed, then that image shows up in the street level panel along with the current image’s attribution. As you flip through the images along the in-processing track, the street panel appears to be stuck.

@1ec5 1ec5 added the streetlevel An issue with streetlevel photos label Nov 16, 2017
@1ec5
Copy link
Collaborator Author

1ec5 commented Nov 16, 2017

The image that’s in processing hasn’t been joined up into a track yet, as you can see on the map canvas:

no track

The images going westbound are already processed; the images going eastbound have not been processed and exhibit this bug.

@peterneubauer
Copy link
Contributor

peterneubauer commented Nov 17, 2017

So, the creation of the vector tiles for the sequences is sometimes lagging as it is asynchronous and depends on a lot of other processing going through. We are working on a status page exhibiting the processing time etc, coming soon. Eventually, this data will catch up as the system is catching up to the load right now.

@1ec5
Copy link
Collaborator Author

1ec5 commented Nov 17, 2017

Thanks @peterneubauer, I appreciate that there’s a significant amount of processing going on. Is there anything iD can do to make the images’ status clear? Currently you can only tell that the image is processing if you know to click on the mapillary.com link.

@bhousel
Copy link
Member

bhousel commented Jan 26, 2018

Following some suggestions from @oscarlorentzon, this should avoid the problem where the viewer starts out bound to an imageKey that it can't actually move to. Now we initialize the viewer with a null key, and issue moveToKey immediately. This also adds some basic exception handling to moveToKey, which actually returns a promise and might fail. In that case, we just quietly log a message to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streetlevel An issue with streetlevel photos
Projects
None yet
Development

No branches or pull requests

3 participants