Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error moving nodes of residential area in 2.6 #4741

Closed
alex11123 opened this issue Jan 24, 2018 · 3 comments
Closed

Error moving nodes of residential area in 2.6 #4741

alex11123 opened this issue Jan 24, 2018 · 3 comments
Labels
bug A bug - let's fix this!

Comments

@alex11123
Copy link

https://www.openstreetmap.org/edit#map=18/50.92584/-2.30736
Starting today I can no longer move nodes of a certain residential area (linked above). Other residential areas I can move nodes. When trying to edit it just shows a stop sign then snaps back on mouse button release.
Other users on the forum have confirmed the error is present for them as well. There is no obvious reason to block it being moved.
thanks in advance
chrome,windows 10

@bhousel
Copy link
Member

bhousel commented Jan 24, 2018

I agree that it looks like a bug.. I'll try to see what might be causing the node move from being blocked. As a workaround, you can hold down the alt/option key while moving nodes.

@bhousel bhousel added the bug A bug - let's fix this! label Jan 24, 2018
@bhousel
Copy link
Member

bhousel commented Jan 25, 2018

ok, so I figured out why the code is not happy, and it's because r3148989 (the landuse=residential) has an outer ring that touches its inner ring.

They touch here at lng,lat [-2.3042359, 50.9270863]:

screenshot 2018-01-24 19 43 21

I agree that iD should still allow you to move the edge nodes in this situation, since the moved node isn't what caused the problem.

@bhousel
Copy link
Member

bhousel commented Jan 25, 2018

I relaxed the check a little bit for multipolygon rings.. Now you only get the nope cursor when you try to drag an outer across an inner.. (It's hard to tell what is going on here, but the outer is a landuse=residential and the inner is a landuse=retail)

multipolygon ring nope

I tried to make a simpler version to demonstrate what was wrong, but iD won't let me 😆

multipolygon ring nope2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants