Providing space in conditional restriction not considered as a modification in iD

[krishnanammala]

While trying to modify the conditional restriction for School days of adding space for SH off after ; syntax restriction:conditional=no_u_turn @ (Mo-Fr 09:00-10:00,15:00-16:00; SH off) as per wiki the iD editor is not considering it as a modification and not allowing to upload the data to OpenStreetMap.

iD link, mapillary link

cc @bhousel

[bhousel]

Thanks for reporting @krishnanammala ...

This is one of those weird OSM edge cases. Most of the time OSM expects spaces around ';' removed, but inside of an opening hours string, they want the spaces kept.

We have special code in here to handle the situation:

iD/modules/ui/entity_editor.js

Lines 219 to 229 in e1b72d2

	function keepSpaces(k) {
	return k.match(/_hours|_times/) !== null;
	}
	var blacklist = ['description', 'note', 'fixme'];
	if (_some(blacklist, function(s) { return k.indexOf(s) !== -1; })) return v;
	var cleaned = v.split(';')
	.map(function(s) { return s.trim(); })
	.join(keepSpaces(k) ? '; ' : ';');

I'll have to change this code to apply the space keeping rule whenever a conditional clause is detected.

(using this page for reference with some complex examples:
https://wiki.openstreetmap.org/wiki/Conditional_restrictions )

[bhousel]

Also, it seems like a value can have multiple conditionals, and in this situation they are also semicolon-space delimited:

maxspeed:conditional=120 @ (06:00-20:00); 80 @ wet