-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iD fails to build on Node 10 #5028
Comments
ugh, our build fails on Node 10. I'll need to dig into this more this week. 😞
If I comment out Line 10 in 0ba8aab
|
You're not alone, this one is somewhat similar: GoogleChrome/workbox#1450 |
|
It turned out to be an issue with the older version of We can upgrade |
Version 10 of Node.js (code name Dubnium) has been released! 🎊
To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:
.travis.yml
package.json
files, so that was left aloneIf you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.
More information on this issue
Greenkeeper has checked the
engines
key in anypackage.json
file, the.nvmrc
file, and the.travis.yml
file, if present.engines
was only updated if it defined a single version, not a range..nvmrc
was updated to Node.js 10.travis.yml
was only changed if there was a root-levelnode_js
that didn’t already include Node.js 10, such asnode
orlts/*
. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.For many simpler
.travis.yml
configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
The text was updated successfully, but these errors were encountered: