Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude weird boundary type names from city name suggestions #5034

Closed
matkoniecz opened this issue May 14, 2018 · 2 comments
Closed

Exclude weird boundary type names from city name suggestions #5034

matkoniecz opened this issue May 14, 2018 · 2 comments
Labels
usability An issue with ease-of-use or design

Comments

@matkoniecz
Copy link
Contributor

For example within https://www.openstreetmap.org/relation/4749311 (boundary=religious_administration) address suggestion fields include "Dekanat Kraków-Prądnik" in city dropdown menu in addition to expected "Kraków".

selection_014

@bhousel
Copy link
Member

bhousel commented May 14, 2018

I think it's coming from this block of code:

function isAddressable(d) {
if (d.tags.name &&
(d.tags.admin_level === '8' || d.tags.border_type === 'city'))
return true;
if (d.tags.place && d.tags.name && (
d.tags.place === 'city' ||
d.tags.place === 'town' ||
d.tags.place === 'village'))
return true;
if (d.tags['addr:city']) return true;
return false;
}
}

@bhousel
Copy link
Member

bhousel commented May 14, 2018

yeah it's the admin_level=8 part

@bhousel bhousel added the usability An issue with ease-of-use or design label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants