UCX/RNDV/CUDA: RNDV protocol improvements for CUDA - v1.9.x #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
changed the title
brminich
reviewed
Sep 7, 2020
src/ucp/core/ucp_context.h
Outdated
| @@ -61,6 +61,8 @@ typedef struct ucp_context_config { | |||
| size_t seg_size; | |||
| /** RNDV pipeline fragment size */ | |||
| size_t rndv_frag_size; | |||
| /** RNDV pipline send threshold */ | |||
hoopoepg
reviewed
Sep 7, 2020
src/ucp/tag/rndv.c
Outdated
| } | ||
|
|
||
| if (ucs_popcount(lane_map) > 1) { | ||
| /* remove lanes if bandwidth is too less compare to best lane */ |
There was a problem hiding this comment.
remove lanes if bandwidth is too low comparing to the best lane
hoopoepg
approved these changes
Sep 7, 2020
yosefe
reviewed
Sep 7, 2020
| rndv_rts_hdr->size); | ||
|
|
||
| if ((rndv_mode == UCP_RNDV_MODE_PUT_ZCOPY) || | ||
| UCP_MEM_IS_CUDA(rreq->recv.mem_type)) { |
There was a problem hiding this comment.
why need to check cuda here?
There was a problem hiding this comment.
in default UCP_RNDV_MOD_AUTO, we try to use PUT protocol for CUDA IPC case.
yosefe
approved these changes
Sep 9, 2020
|
bot:pipe:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
porting #5473 from master